Skip to content

Conversation

@Kerberross
Copy link
Contributor

Migrate the addon to godot 4 (tested with beta 8)

Main change:

  • automatic migration by godot (when opening a 3.* project with godot 4)
  • some method signature changed (mainly in EditorImportPlugin)
  • File api changed (File -> FileAccess)
  • exported stex changed to ctex
    stex doesn't seems to be working anymore in godot 4, it's a ctex file which is created now on image import
    also changed in this streaming file is the image format: when importing a png, godot transform it to a webp, I have used the same format here.

I also changed to github workflow to make use of the lasted gdtoolkit for 4.0, which is not yet available on pypi

@Technohacker
Copy link
Owner

Thank you for the PR! I'll probably branch off the current 3.x code once this gets merged so there's still a version available for 3.x projects

How stable is 4.0's API now? I might wait until first stable lands before merging this, keeping this PR as a staging branch for 4.0 changes if that's not an issue :)

@Kerberross
Copy link
Contributor Author

From what I read, since the version 4 is in beta, the api shoudn't change a lot, but we will see.

I am working a game with versino 4, so I will keep it updated if something break when a new beta will come out. It may just take some times to updated it, since I am working on it on my free time, and so not every days.

@Kerberross
Copy link
Contributor Author

Now also include the #9 pull request

@Technohacker
Copy link
Owner

Now that 4.0 is out, I'm open to merging this if there's no changes to be made :)

@Kerberross
Copy link
Contributor Author

Hello, I didn't have time to test with the latest releases candidate or the release version, I will test on last time this weekend and will come back to you after.
But the code should be ready.

@Technohacker
Copy link
Owner

No problem 👍

@Kerberross
Copy link
Contributor Author

@Technohacker It should be good to merge, there was only a small signature change (int -> Error), and I re-changed the gdtoolkit to the pypi one, since the 4.0 was published the 1st march

@Technohacker
Copy link
Owner

Note to self: Don't use GitHub's editor to fix formatting 😅

@Technohacker Technohacker merged commit 0cf76ea into Technohacker:master Mar 6, 2023
@Technohacker
Copy link
Owner

Thank you again for the PR! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants