-
Notifications
You must be signed in to change notification settings - Fork 12
Migrate addon to godot 4.0 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for the PR! I'll probably branch off the current 3.x code once this gets merged so there's still a version available for 3.x projects How stable is 4.0's API now? I might wait until first stable lands before merging this, keeping this PR as a staging branch for 4.0 changes if that's not an issue :) |
|
From what I read, since the version 4 is in beta, the api shoudn't change a lot, but we will see. I am working a game with versino 4, so I will keep it updated if something break when a new beta will come out. It may just take some times to updated it, since I am working on it on my free time, and so not every days. |
…the pxo file instead of a parameter
…t_pixelorama_importer into godot_4_0_mig
|
Now also include the #9 pull request |
|
Now that 4.0 is out, I'm open to merging this if there's no changes to be made :) |
|
Hello, I didn't have time to test with the latest releases candidate or the release version, I will test on last time this weekend and will come back to you after. |
|
No problem 👍 |
…y gdformat/gdlint
|
@Technohacker It should be good to merge, there was only a small signature change (int -> Error), and I re-changed the gdtoolkit to the pypi one, since the 4.0 was published the 1st march |
|
Note to self: Don't use GitHub's editor to fix formatting 😅 |
b429597 to
63013bb
Compare
|
Thank you again for the PR! :D |
Migrate the addon to godot 4 (tested with beta 8)
Main change:
stex doesn't seems to be working anymore in godot 4, it's a ctex file which is created now on image import
also changed in this streaming file is the image format: when importing a png, godot transform it to a webp, I have used the same format here.
I also changed to github workflow to make use of the lasted gdtoolkit for 4.0, which is not yet available on pypi