-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: arm compatible build #15
Conversation
fix: drop decorator
0537b0e
to
2c23924
Compare
All that poetry changes are needed for ARM compatibility? If not, please limit the PR to the minimum ones. If yes, please explain each of them. |
honestly just ran I do not have a problem testing it and figuring out. If the time is useful. At the end of the day the multi build would still need run as well. looks like dropping changes to dev deps will reduce a lot of the lock diff. |
My fear on this is that updating all the stack, any incompatibility arises, so I was betting for a controlled change. In general, it's good to update everything to the latest possible versions, but not assuring that this doesn't provoke any problem is risky. For example, one question I have seeing the other files is why adding a new dependency ( |
hoping: this is ok or should pre-commit packages be left in place if not causing a specific error? |
I think you are right and https://docs.python.org/3.10/library/asyncio-task.html#generator-based-coroutines FROM python:3-alpine would need pinned to an old version it must be pulling ^3.11 if removed |
understood. #16 minimal change and running on a current build. my motivation, to allow what looks like the only complex part on running https://github.com/Tecnativa/doodba on the M series arm chips for loco dev work, is this image in the copier template: https://github.com/Tecnativa/doodba-copier-template/blob/main/devel.yaml.jinja#L14C38-L14C38 ( fork, update, build, publish, update references in compose files ...) I have not run into any other issues and might be nice to have that support out of the box? I mean more useful that RISC-V for now Kencove#1 this is about as far as I could get with the test, on my account to run without approval. I would probably invest a little to get an arm arch to your specs here. But may have to hand off to @JordiBForgeFlow as I am not custom to using tests on GitHub. well the gnu date to timestamp syntax if needed in scripts.
|
ARM support added in #17 |
registry.gitlab.com/kencove/docker-whitelist/add-gitlab-ci:latest
here is an image for review.