Skip to content

Commit

Permalink
Optimize the log output of obdiag analyze memory (oceanbase#579)
Browse files Browse the repository at this point in the history
  • Loading branch information
Teingi authored Nov 27, 2024
1 parent 7902192 commit 04260f8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions handler/analyzer/analyze_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ def __handle_from_node(self, node, local_store_parent_dir):
if resp["skip"]:
return resp
self.stdio.print(FileUtil.show_file_list_tabulate(remote_ip, log_list, self.stdio))
self.stdio.print("analyze log. Please wait a moment...")
self.stdio.start_loading("analyze memory start")
for log_name in log_list:
if self.directly_analyze_files:
Expand Down Expand Up @@ -567,6 +568,8 @@ def __parse_memory_label(self, file_full_path):
except Exception as e:
self.stdio.warn('parse memory label failed, error: {0}'.format(e))
continue
if len(memory_print_line_list) == 0 and self.directly_analyze_files:
self.stdio.warn('failed to get memory information. Please confirm that the file:{0} and version:{1} you are passing are consistent'.format(file_full_path, self.version))
return sorted(memory_print_line_list)

def __convert_string_bytes_2_int_bytes(self, string_bytes):
Expand Down

0 comments on commit 04260f8

Please sign in to comment.