Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ldap fix creation mail #71

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Ldap fix creation mail #71

wants to merge 3 commits into from

Conversation

c00k133
Copy link
Member

@c00k133 c00k133 commented Sep 16, 2019

This PR changes the order in which LDAP password is created for a user to ensure that data is saved even if mail sending fails.

Additionally, setup.cfg is updated with [flake8] settings as well.

@c00k133 c00k133 added the bug label Sep 16, 2019
@c00k133 c00k133 requested a review from tlangens September 16, 2019 16:20
@coveralls
Copy link

coveralls commented Sep 16, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 55.723% when pulling 60ede71 on ldap-fix-creation-mail into c4fd037 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlangens tlangens Awaiting requested review from tlangens

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c00k133 @coveralls