Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /claim-your-gift and fix bugs #1987

Merged
merged 10 commits into from
Nov 29, 2024

Conversation

marcoskolodny
Copy link
Contributor

No description provided.

@marcoskolodny marcoskolodny changed the base branch from production to mistica-design-site November 29, 2024 13:07
stroke: ${color};
}
`;
useLayoutEffect(() => {
Copy link
Contributor Author

@marcoskolodny marcoskolodny Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid snake animation from restarting in every new render. This was happening for example every time you pressed a button or updated something in any page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't look at this ugly hack, I had to hardcode the entire font in base64 in order for the downloaded svg to use the correct font

const timeToRelease = Math.max(0, targetDate.getTime() - now.getTime());
const timeToRelease = Math.max(
0,
Math.min(2147483647, targetDate.getTime() - now.getTime())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setTimeout only supports numbers lower than 2³²

@@ -61,21 +56,6 @@ const CalendarView = () => {
};

const [achievements, setAchievements] = useState([]);
const [availableDays, setAvailableDays] = useState([]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused code

@@ -62,26 +60,6 @@ const ProgressView = () => {
setAchievements(achievementsState);
}, []);

const handleClearData = () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused code

@marcoskolodny marcoskolodny merged commit 0243af9 into mistica-design-site Nov 29, 2024
1 check passed
@marcoskolodny marcoskolodny deleted the mkolodny/claim-your-gift branch November 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant