Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): export mistica tokens as public css custom properties #1161

Merged
merged 6 commits into from
Jul 15, 2024
Merged

feat(css): export mistica tokens as public css custom properties #1161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0b077f
WEB-1703 feat(css): export mistica tokens as public css custom proper…
atabel Jul 1, 2024
7839c66
update screenshots
atabel Jul 2, 2024
7679f36
add boxed
atabel Jul 2, 2024
186f32e
Merge branch 'master' into atoledano-css
atabel Jul 8, 2024
d01498a
fix text presets. Remove border radius utility classes
atabel Jul 8, 2024
86af5ae
update screenshots
atabel Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
689 changes: 689 additions & 0 deletions css/blau.css
View file
Open in desktop

Large diffs are not rendered by default.

158 changes: 158 additions & 0 deletions css/mistica-common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,158 @@
/* Default text color */
[data-mistica-skin] {
color: var(--mistica-color-textPrimary);
background: var(--mistica-color-background);
}

/* border-radius utility classes */
.mistica-border-radius-avatar {
Copy link
Contributor Author

@atabel atabel Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if border-radius utility classes are worth, maybe having the css vars is enough. Wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case? It seems like the CSS var could be enough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. If we need the class in the future, we can add it, but for now I think we can live with the vars

border-radius: var(--mistica-border-radius-avatar);
}
.mistica-border-radius-bar {
border-radius: var(--mistica-border-radius-bar);
}
.mistica-border-radius-button {
border-radius: var(--mistica-border-radius-button);
}
.mistica-border-radius-checkbox {
border-radius: var(--mistica-border-radius-checkbox);
}
.mistica-border-radius-container {
border-radius: var(--mistica-border-radius-container);
}
.mistica-border-radius-indicator {
border-radius: var(--mistica-border-radius-indicator);
}
.mistica-border-radius-input {
border-radius: var(--mistica-border-radius-input);
}
.mistica-border-radius-legacyDisplay {
border-radius: var(--mistica-border-radius-legacyDisplay);
}
.mistica-border-radius-popup {
border-radius: var(--mistica-border-radius-popup);
}
.mistica-border-radius-sheet {
border-radius: var(--mistica-border-radius-sheet);
}
.mistica-border-radius-mediaSmall {
border-radius: var(--mistica-border-radius-mediaSmall);
}

/* text utility classes */
.mistica-text-1 {
font-size: var(--mistica-font-size-1);
line-height: var(--mistica-line-height-1);
font-weight: var(--mistica-font-weight-1);
}
.mistica-text-2 {
font-size: var(--mistica-font-size-2);
line-height: var(--mistica-line-height-2);
font-weight: var(--mistica-font-weight-2);
}
.mistica-text-3 {
font-size: var(--mistica-font-size-3);
line-height: var(--mistica-line-height-3);
font-weight: var(--mistica-font-weight-3);
}
.mistica-text-4 {
font-size: var(--mistica-font-size-4);
line-height: var(--mistica-line-height-4);
font-weight: var(--mistica-font-weight-4);
}
.mistica-text-5 {
font-size: var(--mistica-font-size-5);
line-height: var(--mistica-line-height-5);
font-weight: var(--mistica-font-weight-5);
}
.mistica-text-6 {
font-size: var(--mistica-font-size-6);
line-height: var(--mistica-line-height-6);
font-weight: var(--mistica-font-weight-6);
}
.mistica-text-7 {
font-size: var(--mistica-font-size-7);
line-height: var(--mistica-line-height-7);
font-weight: var(--mistica-font-weight-7);
}
.mistica-text-8 {
font-size: var(--mistica-font-size-8);
line-height: var(--mistica-line-height-8);
font-weight: var(--mistica-font-weight-8);
}
.mistica-text-9 {
font-size: var(--mistica-font-size-9);
line-height: var(--mistica-line-height-9);
font-weight: var(--mistica-font-weight-9);
}
.mistica-text-10 {
font-size: var(--mistica-font-size-10);
line-height: var(--mistica-line-height-10);
font-weight: var(--mistica-font-weight-10);
}
.mistica-text-cardTitle {
font-size: var(--mistica-font-size-cardTitle);
line-height: var(--mistica-line-height-cardTitle);
font-weight: var(--mistica-font-weight-cardTitle);
}
.mistica-text-button {
font-size: var(--mistica-font-size-button);
line-height: var(--mistica-line-height-button);
font-weight: var(--mistica-font-weight-button);
}
.mistica-text-tabsLabel {
font-size: var(--mistica-font-size-tabsLabel);
line-height: var(--mistica-line-height-tabsLabel);
font-weight: var(--mistica-font-weight-tabsLabel);
}
.mistica-text-link {
font-size: var(--mistica-font-size-link);
line-height: var(--mistica-line-height-link);
font-weight: var(--mistica-font-weight-link);
}
.mistica-text-title1 {
font-size: var(--mistica-font-size-title1);
line-height: var(--mistica-line-height-title1);
font-weight: var(--mistica-font-weight-title1);
}
.mistica-text-title2 {
font-size: var(--mistica-font-size-title2);
line-height: var(--mistica-line-height-title2);
font-weight: var(--mistica-font-weight-title2);
}
Copy link
Contributor

@aweell aweell Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should add title3 to tokens.json so users can have all title sizes available. WDYT @yceballost

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me! and we will need to include also title4 soon, right?

.mistica-text-indicator {
font-size: var(--mistica-font-size-indicator);
line-height: var(--mistica-line-height-indicator);
font-weight: var(--mistica-font-weight-indicator);
}
.mistica-text-navigationBar {
font-size: var(--mistica-font-size-navigationBar);
line-height: var(--mistica-line-height-navigationBar);
font-weight: var(--mistica-font-weight-navigationBar);
}

/* Responsive layout */
.mistica-responsive-layout {
padding-left: env(safe-area-inset-left);
padding-right: env(safe-area-inset-right);
margin: 0 var(--mistica-responsive-layout-margin);
--mistica-responsive-layout-margin: 16px;
}

@media (min-width: 768px) {
.mistica-responsive-layout {
--mistica-responsive-layout-margin: 24px;
}
}

@media (min-width: 1024px) {
.mistica-responsive-layout {
--mistica-responsive-layout-margin: 40px;
}
}

@media (min-width: 1368px) {
.mistica-responsive-layout {
--mistica-responsive-layout-margin: calc((100vw - 1224px) / 2);
}
}
Comment on lines +106 to +130
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to include some basic utility classes like this here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least a basic one like responsive-layout, yes. But I wouldn't add many of them

Loading
Loading