Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProgressBarStepped): create component #905

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

marcoskolodny
Copy link
Contributor

Issue: Link
Specs: Link

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Size stats

master this branch diff
Total JS 9.51 MB 9.51 MB +2.56 kB
JS without icons 999 kB 1 MB +2.5 kB
Lib overhead 126 kB 127 kB +313 B
Lib overhead (gzip) 32.5 kB 32.5 kB +78 B

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-iz7a96v2i-tuentisre.vercel.app

Built with commit 94961f9.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@marcoskolodny marcoskolodny marked this pull request as ready for review October 9, 2023 16:00
src/__stories__/progress-bar-story.tsx Outdated Show resolved Hide resolved
/>
);

ProgressBarStory.storyName = 'ProgressBar';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move this up, near ProgressBarStory definition

ProgressBarStory.storyName = 'ProgressBar';
ProgressBarSteppedStory.storyName = 'ProgressBarStepped';

ProgressBarStory.args = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this

@atabel atabel enabled auto-merge October 16, 2023 14:42
@atabel atabel added this pull request to the merge queue Oct 16, 2023
Merged via the queue into master with commit 25ed4eb Oct 16, 2023
@atabel atabel deleted the WEB-1572-progress-bar-stepped branch October 16, 2023 15:04
tuentisre pushed a commit that referenced this pull request Oct 18, 2023
# [14.26.0](v14.25.0...v14.26.0) (2023-10-18)

### Bug Fixes

* **Carousel:** cards bottom border being partially cut in iOS ([#920](#920)) ([754acc6](754acc6))
* **Video, DisplayMediaCard, PosterCard:** show fallback on empty src ([#910](#910)) ([4e366d3](4e366d3))

### Features

* **Accordion:** create Accordion and BoxedAccordion components ([#900](#900)) ([7062a43](7062a43))
* **Icons:** use icon keywords from mistica design in catalog story ([#914](#914)) ([286e385](286e385))
* **Menu:** fix component styles and add MenuItem/MenuSection ([#892](#892)) ([d7a7e30](d7a7e30)), closes [#901](#901)
* **Mobile:** add interaction states when pressing touchable elements ([#912](#912)) ([dbd8ac0](dbd8ac0))
* **OverscrollColor, Storybook:** overscroll alternative variant and storybook default platform detection ([#919](#919)) ([77d9b45](77d9b45))
* **PinField:** new component ([#902](#902)) ([484dbc7](484dbc7)), closes [#893](#893)
* **ProgressBarStepped:** create component ([#905](#905)) ([25ed4eb](25ed4eb))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants