Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Storybook): New UI for Storybook #926

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Conversation

yceballost
Copy link
Contributor

No description provided.

@@ -6,4 +6,7 @@ import {createStorybookTheme} from './storybook-manager-theme';
addons.setConfig({
panelPosition: 'right',
theme: createStorybookTheme('Movistar'),
toolbar: {
title: {hidden: true},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides this element
Screenshot 2023-10-26 at 18 09 52

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Size stats

master this branch diff
Total JS 9.58 MB 9.58 MB 0 B
JS without icons 1.02 MB 1.02 MB 0 B
Lib overhead 126 kB 126 kB 0 B
Lib overhead (gzip) 32.1 kB 32.1 kB 0 B

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-79luffxbe-tuentisre.vercel.app

Built with commit eb424ef.
This pull request is being automatically deployed with vercel-action

@yceballost yceballost marked this pull request as ready for review October 27, 2023 13:45
@yceballost yceballost requested review from atabel and aweell October 27, 2023 13:45
<style type="text/css">
/* styles for the storybook sidebar */
.search-result-item {
border-bottom: 1px solid rgba(0, 0, 0, 0.1) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all those !important needed? There isn't any official way of customizing these storybook styles?

I'm afraid a future update of storybook could break this

Copy link
Contributor Author

@yceballost yceballost Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed !important tag from the most of cases. The cases with !important needs it to force override the styles :(

.storybook/manager-head.html Outdated Show resolved Hide resolved
@atabel atabel added this pull request to the merge queue Nov 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2023
@atabel atabel added this pull request to the merge queue Nov 17, 2023
Merged via the queue into master with commit eefa54e Nov 17, 2023
11 checks passed
@atabel atabel deleted the iceballos-storybook-refresh branch November 17, 2023 10:52
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.32.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants