-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Storybook): New UI for Storybook #926
Conversation
@@ -6,4 +6,7 @@ import {createStorybookTheme} from './storybook-manager-theme'; | |||
addons.setConfig({ | |||
panelPosition: 'right', | |||
theme: createStorybookTheme('Movistar'), | |||
toolbar: { | |||
title: {hidden: true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size stats
|
Accessibility report ℹ️ You can run this locally by executing |
Deploy preview for mistica-web ready! ✅ Preview Built with commit eb424ef. |
.storybook/manager-head.html
Outdated
<style type="text/css"> | ||
/* styles for the storybook sidebar */ | ||
.search-result-item { | ||
border-bottom: 1px solid rgba(0, 0, 0, 0.1) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all those !important
needed? There isn't any official way of customizing these storybook styles?
I'm afraid a future update of storybook could break this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the example from NASA storybook. I can try to remove !important
as much as possible
https://github.com/nasa-jpl/explorer-1/blob/main/storybook/manager-head.html
https://storybook.js.org/docs/react/configure/theming#css-escape-hatches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed !important
tag from the most of cases. The cases with !important
needs it to force override the styles :(
🎉 This PR is included in version 14.32.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.