Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FeedbackLoader): CHECKOUT-6410 Add FeedbackLoader to Mistica Community #932

Closed
wants to merge 1 commit into from

Conversation

Marcosld
Copy link
Contributor

@Marcosld Marcosld commented Nov 3, 2023

No description provided.

@Marcosld Marcosld self-assigned this Nov 3, 2023
@Marcosld Marcosld changed the title CHECKOUT-6410 Add FeedbackLoader to Mistica Community feat (FeedbackLoader): CHECKOUT-6410 Add FeedbackLoader to Mistica Community Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Size stats

master this branch diff
Total JS 9.57 MB 9.99 MB +420 kB
JS without icons 1.01 MB 1.43 MB +420 kB
Lib overhead 127 kB 127 kB 0 B
Lib overhead (gzip) 32.6 kB 32.6 kB 0 B

@Marcosld Marcosld changed the title feat (FeedbackLoader): CHECKOUT-6410 Add FeedbackLoader to Mistica Community feat(FeedbackLoader): CHECKOUT-6410 Add FeedbackLoader to Mistica Community Nov 3, 2023
@Marcosld Marcosld marked this pull request as ready for review November 3, 2023 10:30
@Marcosld Marcosld requested a review from pladaria November 3, 2023 10:30
Copy link

github-actions bot commented Nov 3, 2023

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Copy link

github-actions bot commented Nov 3, 2023

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-cb8zyxsl7-tuentisre.vercel.app

Built with commit 99c8101.
This pull request is being automatically deployed with vercel-action

@yceballost
Copy link
Contributor

This component need an evolution to be included in Mística. Vivo is evolving the specs to remove some problems with animation definition. https://jira.tid.es/browse/OBVIVO-2050

@Marcosld
Copy link
Contributor Author

Marcosld commented Nov 6, 2023

This component need an evolution to be included in Mística. Vivo is evolving the specs to remove some problems with animation definition. https://jira.tid.es/browse/OBVIVO-2050

What I've been told is the component would be added by us as it is to Mistica Community and then evolved with the new specs before being moved to real mistica. Should I cancel the PR and close the task?

@Marcosld Marcosld requested a review from yceballost November 6, 2023 09:21
@atabel
Copy link
Contributor

atabel commented Nov 7, 2023

Hi @Marcosld, Design Core (cc @yceballost) have the idea of making this component more global with the intention of adding it to mistica core (instead of community). They are working on global specs for the component. Once the specs are ready we can continue with this, and this PR could be a good starting point. Meanwhile we can keep this PR as draft.

Are you fine with this approach?

@Marcosld Marcosld marked this pull request as draft November 7, 2023 16:03
@Marcosld Marcosld closed this Nov 22, 2023
@marcoskolodny marcoskolodny deleted the CHECKOUT-6410 branch December 1, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants