Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace material lib by material3 lib and enable edge to edge #ANDROID-15563 #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juangardi21
Copy link
Contributor

🥅 What's the goal?

Replace material lib by material3 lib and enable edge to edge and fix components to support it.

🚧 How do we do it?

  • Replace material lib by material3. Both app and library gradle
  • Fix components which have been modified between two libs
  • Apply Spacers with windowInsets at the top and at the bottom of the Columns

📘 Documentation changes?

  • No docs to update nor create

🧪 How can I test this?

  • 🖼️ Screenshots/Videos
  • Android 15 real device:
Grabacion.de.pantalla.2024-12-20.a.las.12.52.01.mov
  • Android 14 emulator:
Grabacion.de.pantalla.2024-12-20.a.las.12.56.57.mov

@juangardi21 juangardi21 marked this pull request as ready for review December 20, 2024 11:58
@@ -322,15 +334,15 @@ fun EditableBooleanTweakEntryBody(
},
shouldShowOverriddenLabel = isOverridden
) {
CompositionLocalProvider(LocalMinimumInteractiveComponentEnforcement provides false) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LocalMinimumInteractiveComponentEnforcement was deprecated

Copy link
Member

@jdelga jdelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@juangardi21
Copy link
Contributor Author

juangardi21 commented Dec 20, 2024

@jdelga I've applied new commit: f83c895. Now edge to edge works as expected:

Before After
Grabacion.de.pantalla.2024-12-20.a.las.14.16.12.mov
Grabacion.de.pantalla.2024-12-20.a.las.14.17.10.mov

@juangardi21 juangardi21 requested a review from jdelga December 20, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants