Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce automatic session tracking & enhance default parameters (targeting main) #230

Merged
merged 11 commits into from
Feb 14, 2025

Conversation

Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Feb 5, 2025

This closes https://github.com/TelemetryDeck/PirateMetrics/issues/41.

This is simply the feature/pirate-metrics branch with all the unfinished code made private and all TODO comments removed. The goal is to get the already-implemented and automatically sent TelemetryDeck.Acquisition.newInstallDetected signal shipped early in the SDK so we can already provide the "New Users" insight on our Web dashboard.

Note that all of the code was already approved in #225 and #223, therefore no additional review should be needed. Most of the changes here were only to make SwiftLint happy (as the Signal file got too long, I had to split it up).

@Jeehut Jeehut requested a review from winsmith February 5, 2025 22:09
@kkostov
Copy link

kkostov commented Feb 6, 2025

@Jeehut could it be TelemetryDeck.Acquisition.newInstallDetected or are installs and users separate concepts/signals? I plan to work on this tomorrow (TelemetryDeck/KotlinSDK#52) so I can still rename them easily.

@Jeehut
Copy link
Contributor Author

Jeehut commented Feb 7, 2025

@kkostov Oh, my mistake, I just noticed that I mentioned the newUserDetected signal in the PR description, whereas I implemented TelemetryDeck.Acquisition.newInstallDetected which is what we had agreed on in our call.

Basically, the detection of a new user could be done but would be way more complicated (and maybe not possible on other platforms) to implement & explain to developers, so we had decided to simply consider a new install as a new user, which in practice is good enough for the purposes of trend analysis. So in practice, these concepts don't differ as the new installs actually are the new users – forget about the newUserDetected signal I had mentioned earlier, I updated the PR description accordingly!

@kkostov
Copy link

kkostov commented Feb 7, 2025

Awesome, thanks! PR is open.

Copy link
Contributor

@winsmith winsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@Jeehut Jeehut merged commit 0c35879 into main Feb 14, 2025
6 checks passed
@Jeehut Jeehut deleted the feature/new-user branch February 14, 2025 14:45
This was referenced Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants