Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attach): support global attach config #3437

Merged
merged 13 commits into from
Dec 30, 2024
Merged

feat(attach): support global attach config #3437

merged 13 commits into from
Dec 30, 2024

Conversation

liweijie0812
Copy link
Collaborator

@liweijie0812 liweijie0812 commented Dec 25, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(ConfigProvider): 新增attach 配置,支持全局设置popupdialogdrawer的挂载节点

  • fix(Dialog): 修复默认挂载节点非body的异常

  • docs(ConfigProvider): 补充Empty组件的全局配置相关文档

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Dec 25, 2024

完成

@liweijie0812
Copy link
Collaborator Author

/update-snapshot

Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

@uyarn uyarn changed the title Feat/global/attach feat(attach): support global attach config Dec 27, 2024
@liweijie0812
Copy link
Collaborator Author

/update-common

@liweijie0812
Copy link
Collaborator Author

image

dialog 展示在挂载元素区域 受影响无法弹出,原因未知,需排查

@uyarn
Copy link
Collaborator

uyarn commented Dec 30, 2024

image dialog 展示在挂载元素区域 受影响无法弹出,原因未知,需排查

这个我处理了

@uyarn uyarn merged commit a4937de into develop Dec 30, 2024
7 checks passed
@uyarn uyarn deleted the feat/global/attach branch December 30, 2024 09:28
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
16 tasks
uyarn added a commit that referenced this pull request Dec 30, 2024
* feat: support global config attach

* chore: update common

* chore: api update

* fix: test

* fix: test

* chore: update snapshot

* chore: clear typograph  code

* chore: clear typograph  code

* chore: revert irrelevant docs change

* feat: fix config

* feat: fix config

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Uyarn <uyarnchen@gmail.com>
uyarn added a commit that referenced this pull request Dec 30, 2024
* fix(upload): 上传组件图片展示样式优化 (#3429)

* fix(upload): 上传组件图片展示样式优化

* chore: update snapshot

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: radio options support radio button (#3402)

* docs: add readonly in api

* feat(RadioGroup): 单选组使用options时 支持button 模式

* fix(Dialog): fix closeOnOverlayClick default behavior (#3433)

* fix(cascader): change event is triggered unexpectedly when value-type is full (#3435)

* fix(cascader): verify invalid value logic errors and optimize code (#3438)

* feat(radio): support readonly (#3431)

* feat(radio): support readonly

* docs: api update

* feat(Table): support rows highlight  (#3442)

* feat(Table): support row highlight

* chore: update snapshot

* chore: update snapshot

* chore: update snapshot

* fix(PR_COMMENT_CI): resolve auto conflicts (#3443)

* fix(select): `onInputChange` miss callback second parameters (#3427)

* fix(select): `onInputChange` miss callback second parameters

* chore: complete params

* chore: fix lint

---------

Co-authored-by: Uyarn <uyarnchen@gmail.com>

* fix(select): `checkAll` will check all filtered data of `reserveKeyword` (#3440)

* perf(select): `checkAll` will check all to keep the filtered data of `reserveKeyword`

* chore: remove unuse code

* chore(deps):  upgrade vitest 2.1.8 (#3424)

* chore(deps):  upgrade vitest 2.1.8

* chore: use @vitest/coverage-v8

* chore: update snapshot

* chore: fix

* chore: fix

* chore: update snapshot

* chore: update snapshot

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* perf(select): support rendering children when `group` title is not exist  (#3445)

* feat(attach): support global attach config (#3437)

* feat: support global config attach

* chore: update common

* chore: api update

* fix: test

* fix: test

* chore: update snapshot

* chore: clear typograph  code

* chore: clear typograph  code

* chore: revert irrelevant docs change

* feat: fix config

* feat: fix config

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Uyarn <uyarnchen@gmail.com>

* chore: release 1.10.8 (#3447)

* chore: release 1.10.8

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: release 1.10.8-naruto

---------

Co-authored-by: huangchen1031 <huangchen1031@vip.qq.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: myron <myronliu347@gmail.com>
Co-authored-by: betavs <34408516+betavs@users.noreply.github.com>
Co-authored-by: liweijie0812 <674416404@qq.com>
Co-authored-by: 阿菜 Cai <1064425721@qq.com>
@iceyxx6
Copy link

iceyxx6 commented Dec 31, 2024

fix(Dialog): 修复默认挂载节点非body的异常 1.10.8 dialog都跑到body下了,原本组件下写的嵌套的样式直接不生效了,得一个一个把嵌套的样式提出来,挂载的节点默认就组件内不行吗?

@uyarn
Copy link
Collaborator

uyarn commented Dec 31, 2024

fix(Dialog): 修复默认挂载节点非body的异常 1.10.8 dialog都跑到body下了,原本组件下写的嵌套的样式直接不生效了,得一个一个把嵌套的样式提出来,挂载的节点默认就组件内不行吗?

抱歉但是这个确实是默认行为,之前默认在节点内并不是本意,默认设计的行为确实是在body下的

@iceyxx6
Copy link

iceyxx6 commented Dec 31, 2024

fix(Dialog): 修复默认挂载节点非body的异常 1.10.8 dialog都跑到body下了,原本组件下写的嵌套的样式直接不生效了,得一个一个把嵌套的样式提出来,挂载的节点默认就组件内不行吗?

抱歉但是这个确实是默认行为,之前默认在节点内并不是本意,默认设计的行为确实是在body下的
好吧~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants