Skip to content

Commit

Permalink
Remove useless TODO comments (#350)
Browse files Browse the repository at this point in the history
  • Loading branch information
iyangsj authored Aug 1, 2024
1 parent 2cfd71c commit 8f4a73a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
6 changes: 2 additions & 4 deletions src/connection/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -693,8 +693,6 @@ impl Connection {

self.flags.insert(NeedSendAckEliciting);

// TODO: notify pacer on the path

Ok(read)
}

Expand Down Expand Up @@ -1468,7 +1466,7 @@ impl Connection {
let info = PacketInfo {
src: path.local_addr(),
dst: path.remote_addr(),
time: time::Instant::now(), // TODO: Set an appropriate sending time
time: time::Instant::now(),
};
Ok((done, info))
}
Expand Down Expand Up @@ -3177,7 +3175,7 @@ impl Connection {
// current Probe Timeout (PTO).
// See RFC 9000 Section 10.1
let path_pto = match self.paths.get_active_mut() {
Ok(p) => p.recovery.rtt.pto_base(), // TODO: revisit
Ok(p) => p.recovery.rtt.pto_base(),
Err(_) => time::Duration::ZERO,
};
let idle_timeout = cmp::max(idle_timeout, 3 * path_pto);
Expand Down
4 changes: 2 additions & 2 deletions src/connection/recovery.rs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ impl Recovery {
let ack_eliciting = pkt.ack_eliciting;
let sent_size = pkt.sent_size;

pkt.time_sent = now; // TODO: REVISIT
pkt.time_sent = now;
let space = match spaces.get_mut(space_id) {
Some(space) => space,
None => return,
Expand Down Expand Up @@ -286,7 +286,7 @@ impl Recovery {
self.congestion.end_ack();
}

self.pto_count = 0; // TODO: REVISIT
self.pto_count = 0;
self.set_loss_detection_timer(space_id, spaces, handshake_status, now);
Ok((lost_packets, lost_bytes))
}
Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ impl Config {
/// # Ok::<(), tquic::error::Error>(())
/// ```
pub fn new() -> Result<Self> {
// TODO: review default value
let local_transport_params = TransportParams {
initial_max_data: 10485760,
initial_max_stream_data_bidi_local: 5242880,
Expand Down
1 change: 0 additions & 1 deletion src/tls/tls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ pub(crate) struct DefaultTlsConfigSelector {
}

impl TlsConfigSelector for DefaultTlsConfigSelector {
// TODO: support local and peer address.
/// Get default TLS config.
fn get_default(&self) -> Option<Arc<TlsConfig>> {
Some(self.tls_config.clone())
Expand Down

0 comments on commit 8f4a73a

Please sign in to comment.