feat：流水线变量语法支持两种风格 #10576 #10961
Open
feat：流水线变量语法支持两种风格 #10576 #10961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingshewhe
requested review from
irwinsun,
stubenhuang,
royalhuang,
randychen2046 and
tangruotian
as code owners
irwinsun
reviewed
Sep 14, 2024
| @@ -1598,6 +1608,24 @@ abstract class AbsProjectServiceImpl @Autowired constructor( | |||
| deptName: String? | |||
| ) | |||
|
|
|||
| override fun getPipelineDialect(projectId: String): String { | |||
There was a problem hiding this comment.
此方法不需要，统一由项目VO缓存，在修改项目处增加方案提示：注意：该配置可能会影响项目下所有流水线行为，配置更新需要10分钟
irwinsun
reviewed
Sep 14, 2024
| @@ -297,7 +297,7 @@ class SubPipelineRepositoryService @Autowired constructor( | |||
| val trigger = stages.getOrNull(0) | |||
| ?: throw ErrorCodeException(errorCode = ProcessMessageCode.ERROR_PIPELINE_MODEL_NEED_JOB) | |||
| // 检查触发容器 | |||
| val paramsMap = defaultModelCheckPlugin.checkTriggerContainer(trigger) | |||
| val paramsMap = defaultModelCheckPlugin.checkTriggerContainer(trigger, false) | |||
irwinsun
reviewed
Sep 14, 2024
...biz-base/src/main/kotlin/com/tencent/devops/process/service/pipeline/PipelineBuildService.kt
Outdated
Show resolved
Hide resolved
irwinsun
reviewed
Sep 14, 2024
| var newValue = value | ||
| if (dialect.supportUseSingleCurlyBracesVar()) { | ||
| newValue = ObjectReplaceEnvVarUtil.replaceEnvVar(newValue, contextMap).let { | ||
| JsonUtil.toJson(it, false) |
irwinsun
reviewed
Sep 14, 2024
| @@ -31,3 +31,4 @@ const val EXCHANGE_PROJECT_COUNT_LOGIN = "exchange_project_count_login" | |||
| const val ROUTE_PROJECT_COUNT_LOGIN = "route_project_count_login" | |||
| const val QUEUE_PROJECT_COUNT_LOGIN = "queue_project_count_login" | |||
| const val SECRECY_PROJECT_REDIS_KEY = "SECRECY_PROJECT_REDIS_KEY" // 保密项目Key | |||
| const val PROJECT_PIPELINE_DIALECT_REDIS_KEY = "project:pipeline:dialect" | |||
irwinsun
reviewed
Sep 14, 2024
| @@ -378,4 +378,13 @@ interface ServiceProjectResource { | |||
| @QueryParam("englishName") | |||
| englishName: List<String> | |||
| ): Result<List<String>?> | |||
|
|
|||
| @Operation(summary = "获取项目级流水线方言, 流水线编辑/修改时调用") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
方言设计:
引擎执行设计