feat：Post action 中支持获取父任务ID #10968 #11001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kzhou991
requested review from
irwinsun,
mingshewhe,
stubenhuang,
royalhuang,
randychen2046 and
tangruotian
as code owners
|
|
carlyin0801
reviewed
Sep 23, 2024
| @@ -58,6 +58,8 @@ const val CLOSE = "close" // 开关关闭 | |||
| const val ATOM_POST = "post" // 插件post | |||
| const val ATOM_POST_FLAG = "postFlag" // 插件post标识 | |||
| const val ATOM_POST_ENTRY_PARAM = "postEntryParam" // 插件post操作入口参数 | |||
| const val ATOM_POST_PARENT_TASK_ID = "postActionParentTaskId" // 插件后置动作父任务id | |||
There was a problem hiding this comment.
postActionParentTaskId换成parentTaskId
| @@ -256,7 +259,7 @@ open class MarketAtomTask : ITask() { | |||
| // 开关关闭则不再写入插件私有配置到input.json中 | |||
| inputVariables.putAll(getAtomSensitiveConfMap(atomCode)) | |||
| } | |||
| writeInputFile(atomTmpSpace, inputVariables) | |||
| // writeInputFile(atomTmpSpace, inputVariables) | |||
| @@ -151,6 +153,7 @@ open class MarketAtomTask : ITask() { | |||
| val map = JsonUtil.toMutableMap(data) | |||
| // 该插件执行的工作空间绝对路径 | |||
| val workspacePath = workspace.absolutePath | |||
| val additionalOptions = taskParams["additionalOptions"] | |||
There was a problem hiding this comment.
这个变量定义这么靠前干什么，另外"additionalOptions"换成Element::additionalOptions.name更加优雅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.