Open
Conversation
…om event bus Add comprehensive integration tests to prevent regression of the bug fixed in #89 where EventBridge Rule targets were missing the event_bus_name property when using a custom event bus (not default). Changes: - Add eventbridge-rule-lambda integration test app that creates: * A custom EventBus (not default) * A Rule on that custom event bus with Lambda target * A second rule using fromEventBusName pattern - Add helper functions to integ/aws/eventbridge.go: * DescribeEventBridgeRule - get rule details with event bus support * ListEventBridgeTargets - list targets for a rule on a specific event bus - Add validateEventBridgeRuleLambda test validation that: * Verifies rules are created on the correct event bus * Verifies targets can be listed (proving event_bus_name is set correctly) * Tests end-to-end functionality by sending events and verifying Lambda invocation * Tests both direct EventBus creation and fromEventBusName import patterns This test ensures that the event_bus_name property is correctly set on EventBridge targets when using a custom event bus, preventing the error: "Rule <rule-name> does not exist on EventBus default" Regression test for: #89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive integration tests to prevent regression of the bug fixed in #89 where EventBridge Rule targets were missing the event_bus_name property when using a custom event bus (not default).
Changes:
Add eventbridge-rule-lambda integration test app that creates:
Add helper functions to integ/aws/eventbridge.go:
Add validateEventBridgeRuleLambda test validation that:
This test ensures that the event_bus_name property is correctly set on EventBridge targets when using a custom event bus, preventing the error: "Rule does not exist on EventBus default"
Regression test for: #89
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.