Merge #2

2: New-func: Convert params to ptr for consistency r=Jaskaranbir a=Jaskaranbir Co-authored-by: Jaskaranbir <jaskaranbir.dhillon@gmail.com>
TerrexTech · Nov 13, 2018 · 3feadb1 · 3feadb1
2 parents c1aa7dd + 497c128
commit 3feadb1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/framer/framer_suite_test.go b/framer/framer_suite_test.go
@@ -91,7 +91,7 @@ var _ = Describe("Framer", func() {
 		prodCfg := &kafka.ProducerConfig{
 			KafkaBrokers: brokers,
 		}
-		topicCfg := TopicConfig{
+		topicCfg := &TopicConfig{
 			CommandTopic: commandTopic,
 		}
 		f, err := New(context.Background(), prodCfg, topicCfg)
@@ -130,7 +130,7 @@ var _ = Describe("Framer", func() {
 		prodCfg := &kafka.ProducerConfig{
 			KafkaBrokers: brokers,
 		}
-		topicCfg := TopicConfig{
+		topicCfg := &TopicConfig{
 			DocumentTopic: documentTopic,
 		}
 		f, err := New(context.Background(), prodCfg, topicCfg)
@@ -175,7 +175,7 @@ var _ = Describe("Framer", func() {
 		prodCfg := &kafka.ProducerConfig{
 			KafkaBrokers: brokers,
 		}
-		topicCfg := TopicConfig{
+		topicCfg := &TopicConfig{
 			EventTopic: eventTopic,
 		}
 		f, err := New(context.Background(), prodCfg, topicCfg)

diff --git a/framer/new.go b/framer/new.go
@@ -30,7 +30,7 @@ type TopicConfig struct {
 func New(
 	ctx context.Context,
 	prodConfig *kafka.ProducerConfig,
-	topicConfig TopicConfig,
+	topicConfig *TopicConfig,
 ) (*Framer, error) {
 	command := make(chan *model.Command, 256)
 	document := make(chan *model.Document, 256)