Configurable search providers from config #5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add SearchProviderMixin to connect searchProviders with model system - write architecture decission record - port existing search providers to proposed model
… key and add deprecation warning
…on to remove it, and to have time to update everything
- tsify some of the search UI components - properly separate the catalog and search bar - use the recommendedListLength when rendering - use isOpen when rendering - add boundingBoxLimit search bar config param
…it for every search provider
…ray to config.json
zoran995
commented
Feb 18, 2021
|
This is ready for review, if anyone has time to check. |
|
Hi @nf-s I have synced the code with the latest main and it is ready for review. |
|
Hi @zoran995 We will try to review it in the next few weeks. Thanks again 🙂 |
Closed
ljowen
reviewed
Nov 20, 2023
|
|
||
| this._catalogSearchDisposer = reaction( | ||
| () => this.catalogSearchText, | ||
| () => self.catalogSearchText, |
There was a problem hiding this comment.
I don't believe this is needed since arrow functions use the enclosing this value
ljowen
reviewed
Nov 20, 2023
ljowen
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #5141
Requires TerriaJS/TerriaMap#515
After investigation as the best option appears to utilize the existing model system for SearchProviders.
Testing
Default SearchProviders are BingMaps and AustralianGazetteer, need to apply registerSearchProviders and comment out reference to BingMapsSearchProviderViewModel.
Pending
Future work
Checklist