-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable search providers from config #5145
Conversation
- add SearchProviderMixin to connect searchProviders with model system - write architecture decission record - port existing search providers to proposed model
… key and add deprecation warning
…on to remove it, and to have time to update everything
- tsify some of the search UI components - properly separate the catalog and search bar - use the recommendedListLength when rendering - use isOpen when rendering - add boundingBoxLimit search bar config param
…it for every search provider
…ray to config.json
This is ready for review, if anyone has time to check. |
Hi @nf-s I have synced the code with the latest main and it is ready for review. |
Hi @zoran995 We will try to review it in the next few weeks. Thanks again 🙂 |
|
||
this._catalogSearchDisposer = reaction( | ||
() => this.catalogSearchText, | ||
() => self.catalogSearchText, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is needed since arrow functions use the enclosing this
value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tested locally with Bing and Cesium search providers. Couple of small comments
What this PR does
Fixes #5141
Requires TerriaJS/TerriaMap#515
After investigation as the best option appears to utilize the existing model system for SearchProviders.
Testing
Default SearchProviders are BingMaps and AustralianGazetteer, need to apply registerSearchProviders and comment out reference to BingMapsSearchProviderViewModel.
Pending
Future work
Checklist