Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend and feature info for wms difference output. #7243

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Aug 6, 2024

What this PR does

Makes following changes to WMS difference output:

Test me

  1. Open this test link which has a difference output

  2. Ensure the legend shown is for the difference output
    image

  3. Ensure the feature info for the difference item shows the raw data by default.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

Specifies additional properties to apply to the diff output item.
Copy link
Contributor

@nf-s nf-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@na9da na9da merged commit 4d51446 into main Aug 21, 2024
9 checks passed
@na9da na9da deleted the wms-diff-fixes branch August 21, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants