take out props from viewColumn

TeselaGen · Sep 5, 2024 · 11cd746 · 11cd746
1 parent 1299a13
commit 11cd746
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@teselagen/ui",
-  "version": "0.5.23-beta.7",
+  "version": "0.5.23-beta.8",
   "main": "./src/index.js",
   "type": "module",
   "exports": {

diff --git a/packages/ui/src/DataTable/index.js b/packages/ui/src/DataTable/index.js
@@ -538,7 +538,10 @@ const DataTable = ({
       schema.fields = [viewColumn, ...schema.fields];
     }
     if (isOpenable) {
-      schema.fields = [openColumn, ...schema.fields];
+      schema.fields = [
+        openColumn({ onDoubleClick, history }),
+        ...schema.fields
+      ];
     }
     // this must come before handling orderings.
     schema.fields = schema.fields.map(field => {
@@ -632,10 +635,12 @@ const DataTable = ({
     cellRenderer,
     convertedSchema,
     entities,
+    history,
     isInfinite,
     isOpenable,
     isSimple,
     isViewable,
+    onDoubleClick,
     showForcedHiddenColumns,
     tableConfig.columnOrderings,
     tableConfig.fieldOptions,

diff --git a/packages/ui/src/DataTable/viewColumn.js b/packages/ui/src/DataTable/viewColumn.js
@@ -11,20 +11,16 @@ export const viewColumn = {
     return <Icon className="dt-eyeIcon" icon="eye-open" />;
   }
 };
-export const openColumn = {
+export const openColumn = ({ onDoubleClick, history }) => ({
   ...viewColumn,
-  render: (val, record, rowInfo, props) => {
+  render: (val, record, rowInfo) => {
     return (
       <Tooltip content="Open">
         <Button
           onClick={e => {
             e.stopPropagation();
-            props.onDoubleClick &&
-              props.onDoubleClick(
-                rowInfo.original,
-                rowInfo.index,
-                props.history
-              );
+            onDoubleClick &&
+              onDoubleClick(rowInfo.original, rowInfo.index, history);
           }}
           minimal
           small
@@ -34,4 +30,4 @@ export const openColumn = {
       </Tooltip>
     );
   }
-};
+});