disable stability check

TeselaGen · Jul 17, 2024 · 8256ab9 · 8256ab9
1 parent 2ebddf6
commit 8256ab9
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 40 deletions.
diff --git a/packages/ui/cypress/e2e/UploadCsvWizard.spec.js b/packages/ui/cypress/e2e/UploadCsvWizard.spec.js
@@ -638,9 +638,6 @@ a,,desc,,false,dna,misc_feature
     cy.contains(".bp3-dialog", `Description`); //the expected headers should show up
     cy.contains("Review and Edit Data").click();
     cy.get(`.hasCellError`).type("haha{enter}");
-    cy.get(`.hasCellError:last [data-test="tgCell_name"]`).type("haha{enter}", {
-      force: true
-    });
     cy.get(`button:contains(Next File):first`).click();
     cy.get(
       `.bp3-dialog .bp3-tab[aria-selected="true"]:contains(testUploadWizard_messedUpHeaders.csv) .bp3-icon-warning-sign`

diff --git a/packages/ui/src/DataTable/index.js b/packages/ui/src/DataTable/index.js
@@ -102,10 +102,6 @@ const itemSizeEstimators = {
   comfortable: () => 41.34
 };
 
-const useSelectorOptions = {
-  devModeChecks: { stabilityCheck: "never" }
-};
-
 const DataTable = ({
   controlled_pageSize,
   formName = "tgDataTable",
@@ -161,17 +157,15 @@ const DataTable = ({
     reduxFormQueryParams = {},
     reduxFormSearchInput = "",
     reduxFormSelectedEntityIdMap = {}
-  } = useSelector(
-    state =>
-      formValueSelector(formName)(
-        state,
-        "reduxFormCellValidation",
-        "reduxFormEntities",
-        "reduxFormQueryParams",
-        "reduxFormSearchInput",
-        "reduxFormSelectedEntityIdMap"
-      ),
-    useSelectorOptions
+  } = useSelector(state =>
+    formValueSelector(formName)(
+      state,
+      "reduxFormCellValidation",
+      "reduxFormEntities",
+      "reduxFormQueryParams",
+      "reduxFormSearchInput",
+      "reduxFormSelectedEntityIdMap"
+    )
   );
 
   let props = ownProps;

diff --git a/packages/ui/src/DataTable/utils/useTableParams.js b/packages/ui/src/DataTable/utils/useTableParams.js
@@ -14,10 +14,6 @@ import {
 } from "./queryParams";
 import getTableConfigFromStorage from "./getTableConfigFromStorage";
 
-const useSelectorOptions = {
-  devModeChecks: { stabilityCheck: "never" }
-};
-
 /*
 NOTE:
 This haven't been tested yet. It is the first version of what we should replace withTableParams
@@ -161,7 +157,7 @@ export default function useTableParams(
   } = useSelector(state => {
     if (!state.form[formName]) return {};
     return state.form[formName].values || {};
-  }, useSelectorOptions);
+  });
 
   const entities = reduxFormEntities || _origEntities;
 

diff --git a/packages/ui/src/UploadCsvWizard.js b/packages/ui/src/UploadCsvWizard.js
@@ -21,10 +21,6 @@ import { addSpecialPropToAsyncErrs } from "./FormComponents/tryToMatchSchemas";
 import { cloneDeep } from "lodash-es";
 import { InputField } from "./FormComponents";
 
-const useSelectorOptions = {
-  devModeChecks: { stabilityCheck: "never" }
-};
-
 const getInitialSteps = csvValidationIssue => [
   { text: "Review Headers", active: csvValidationIssue },
   { text: "Review Data", active: !csvValidationIssue }
@@ -91,7 +87,7 @@ const UploadCsvWizardDialog = compose(
         finishedFiles
       };
     }
-  }, useSelectorOptions);
+  });
 
   const [hasSubmittedOuter, setSubmittedOuter] = useState();
   const [steps, setSteps] = useState(getInitialSteps(true));
@@ -320,14 +316,12 @@ const UploadCsvWizardDialogInner = reduxForm()(({
   const [hasSubmitted, setSubmitted] = useState(!csvValidationIssue);
   const [steps, setSteps] = useState(getInitialSteps(csvValidationIssue));
 
-  const { reduxFormEntities, reduxFormCellValidation } = useSelector(
-    state =>
-      formValueSelector(datatableFormName)(
-        state,
-        "reduxFormEntities",
-        "reduxFormCellValidation"
-      ),
-    useSelectorOptions
+  const { reduxFormEntities, reduxFormCellValidation } = useSelector(state =>
+    formValueSelector(datatableFormName)(
+      state,
+      "reduxFormEntities",
+      "reduxFormCellValidation"
+    )
   );
 
   let inner;
@@ -568,13 +562,11 @@ export const SimpleInsertDataDialog = compose(
 }) => {
   const dispatch = useDispatch();
   const reduxFormEntities = useSelector(
-    state => state.form?.simpleInsertEditableTable?.values.reduxFormEntities,
-    useSelectorOptions
+    state => state.form?.simpleInsertEditableTable?.values.reduxFormEntities
   );
   const reduxFormCellValidation = useSelector(
     state =>
-      state.form?.simpleInsertEditableTable?.values.reduxFormCellValidation,
-    useSelectorOptions
+      state.form?.simpleInsertEditableTable?.values.reduxFormCellValidation
   );
   const { entsToUse, validationToUse } = useMemo(
     () => removeCleanRows(reduxFormEntities, reduxFormCellValidation),