-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global roles propagated to tenants #395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byewokko
changed the title
Shared roles (Globally defined roles scoped for individual tenants)
Shared roles - Globally defined roles scoped to individual tenants
Jun 24, 2024
byewokko
changed the title
Shared roles - Globally defined roles scoped to individual tenants
Globally defined roles scoped to individual tenants
Jul 9, 2024
byewokko
changed the title
Globally defined roles scoped to individual tenants
Globally defined tenant roles
Jul 9, 2024
byewokko
changed the title
Globally defined tenant roles
Global roles propagated to tenants
Jul 17, 2024
ateska
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark to naming, otherwise mergeable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #357
Summary
Compatibility
Propagated global roles
propagated=true
.~
after the slash in their ID. E.g. a global role called*/reader
is propagated asmytenant/~reader
,yourtenant/~reader
etc.propagated
flag is not editable after role creation. Changes to the global role propagate immediately to its propagated tenant roles.Tech details
RoleView
class - global, global propagated and tenant - for listing, searching and getting the three different types of roles.SessionContext
, a context variable that holds the auth session of the request.