Refactor: Move HelloService to the test suite

- Refactor: HelloService is just an example; it doesn't need to be part of stackinabox proper. Moved it over to the test suite.
TestInABox · Apr 21, 2018 · f299293 · f299293
1 parent 07cb96c
commit f299293
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 12 deletions.
diff --git a/docs/changes/latest.rst b/docs/changes/latest.rst
@@ -12,6 +12,7 @@ Breaking Changes
   switch just by changing the imports. Previously the utility being supported
   had its name in the methods, thus requiring more significant code changes
   if one decided to change utilities.
+- Moved the HelloService example from stackinabox proper to the test suite
 
 Fixed
 -----

diff --git a/docs/user/quickstart.rst b/docs/user/quickstart.rst
@@ -38,7 +38,8 @@ to use the Stack-In-A-Box in an actual test:
 
     import stackinabox.util.requests_mock
     from stackinabox.stack import StackInABox
-    from stackinabox.services.hello import HelloService
+    # from the stackinabox test suite...
+    from tests.utils.hello import HelloService
 
     class TestRequestsMock(unittest.TestCase):
 

diff --git a/tests/test_stack.py b/tests/test_stack.py
@@ -7,13 +7,13 @@
 import requests
 
 from stackinabox import stack
-from stackinabox.services import (
-    hello,
-    service
-)
+from stackinabox.services import service
 import stackinabox.util.httpretty
 
-from tests.utils import services as test_services
+from tests.utils import (
+    hello,
+    services as test_services
+)
 
 
 class ExceptionalServices(service.StackInABoxService):

diff --git a/tests/util/httpretty/test_core.py b/tests/util/httpretty/test_core.py
@@ -11,9 +11,9 @@
 
 import stackinabox.util.httpretty
 from stackinabox.stack import StackInABox
-from stackinabox.services.hello import HelloService
 
 from tests.utils.services import AdvancedService
+from tests.utils.hello import HelloService
 
 
 logger = logging.getLogger(__name__)

diff --git a/tests/util/httpretty/test_decorator.py b/tests/util/httpretty/test_decorator.py
@@ -8,9 +8,9 @@
 import requests
 
 from stackinabox.util.httpretty import decorator
-from stackinabox.services.hello import HelloService
 
 from tests.utils.services import AdvancedService
+from tests.utils.hello import HelloService
 
 
 class TestHttprettyBasicWithDecoratorErrors(unittest.TestCase):

diff --git a/tests/util/requests_mock/test_core.py b/tests/util/requests_mock/test_core.py
@@ -14,9 +14,9 @@
 import stackinabox.util.requests_mock
 from stackinabox.util.requests_mock import core
 from stackinabox.stack import StackInABox
-from stackinabox.services.hello import HelloService
 
 from tests.utils.services import AdvancedService
+from tests.utils.hello import HelloService
 
 
 logger = logging.getLogger(__name__)

diff --git a/tests/util/requests_mock/test_decorator.py b/tests/util/requests_mock/test_decorator.py
@@ -10,9 +10,9 @@
 import requests
 
 from stackinabox.util.requests_mock import decorator
-from stackinabox.services.hello import HelloService
 
 from tests.utils.services import AdvancedService
+from tests.utils.hello import HelloService
 
 
 logger = logging.getLogger(__name__)

diff --git a/tests/util/response/test_core.py b/tests/util/response/test_core.py
@@ -11,9 +11,9 @@
 
 import stackinabox.util.responses
 from stackinabox.stack import StackInABox
-from stackinabox.services.hello import HelloService
 
 from tests.utils.services import AdvancedService
+from tests.utils.hello import HelloService
 
 
 logger = logging.getLogger(__name__)

diff --git a/tests/util/response/test_decorator.py b/tests/util/response/test_decorator.py
@@ -10,9 +10,9 @@
 import requests
 
 from stackinabox.util.responses import decorator
-from stackinabox.services.hello import HelloService
 
 from tests.utils.services import AdvancedService
+from tests.utils.hello import HelloService
 
 
 logger = logging.getLogger(__name__)

diff --git a/stackinabox/services/hello/__init__.py → tests/utils/hello/__init__.py b/stackinabox/services/hello/__init__.py → tests/utils/hello/__init__.py