Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Elliptic Curve
S256
, akasecp256k1
. The curve is defined in Standards for Efficient Cryptography, SEC 2: Recommended Elliptic Curve Domain Parameters, Section 2.4.1 and commonly used in Blockchain systems, starting with Bitcoin. See Bitcoin Wiki secp256k1.Go Version Change
Due to the minimum requirement of the library dependency on
github.com/decred/dcrd/dcrec/secp256k1/v4
v4.1.0, this change increases the minimum version of go to1.17
.Travis CI failures
1.13
.If you could update Travis CI to use Go
1.17
those errors would be resolved.PR Additions
github.com/decred/dcrd/dcrec/secp256k1/v4
v4.1.0 which is a copyfree license and includes the Name in the Curve params, "secp256k1" which is the same name used by HSMs, such as AWS Cloud HSM,openssl
and SoftHSM2.asn1.ObjectIdentifier{1, 3, 132, 0, 10}
is correct for secp256k1, see oid-info.comThe contents of this PR with
secp256k1
have been used in an internal project that used SoftHSM2.