Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis reexported in vinted-rs 0.9.2 #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Redis reexported in vinted-rs 0.9.2 #115

wants to merge 1 commit into from

Conversation

pxp9
Copy link
Contributor

@pxp9 pxp9 commented Oct 9, 2024

No description provided.

@pxp9 pxp9 requested a review from 0xCAB0 October 9, 2024 22:06
0xCAB0
0xCAB0 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@0xCAB0 0xCAB0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. DON'T forget to update the Readme.

Could we also export another crate?
I guess if we are migrating from type builder it doesn't make much sense, but maybe there're also other crates we should share version.

@0xCAB0
Copy link
Member

0xCAB0 commented Oct 9, 2024

Also update the Changelog pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xCAB0 0xCAB0 0xCAB0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxp9 @0xCAB0