Skip to content

feat: implement video length selection in TopicVideoGenerator #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suganth07 wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

feat: implement video length selection in TopicVideoGenerator #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
01bc41f
feat: implement video length selection in TopicVideoGenerator
suganth07 Jan 25, 2026
68d0bab
fix: Code Rabbit
suganth07 Jan 25, 2026
784965e
Include migrations folder for production build
suganth07 Jan 25, 2026
b4c7841
Fix Android app icon to use custom SkillSpark icon
suganth07 Jan 25, 2026
fe626dd
Fix database initialization to ensure migrations run before queries
suganth07 Jan 25, 2026
6e87170
Fix production APK database initialization with complete migrations a…
suganth07 Jan 25, 2026
f2e29c4
fix: emotion in apk
suganth07 Jan 26, 2026
6a7ab07
Add MediaPipe face_landmarker model for emotion detection in producti…
suganth07 Jan 26, 2026
0a602ec
Add Expo plugin to properly bundle emotion detection model in EAS builds
suganth07 Jan 26, 2026
b21357f
Fix .easignore for EAS build
suganth07 Jan 26, 2026
a8b0eba
Remove .easignore - use default gitignore behavior
suganth07 Jan 26, 2026
09e6530
Add face-landmarks module to dependencies for EAS Build
suganth07 Jan 26, 2026
e6c45d3
Update lockfile for face-landmarks module
suganth07 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

# dependencies
node_modules/
db/migrations/
# Expo
.expo/
dist/
Expand Down Expand Up @@ -38,13 +37,13 @@ yarn-error.*

app-example

# Drizzle
db/migrations/

# Ignore the entire Android directory
android/
# But keep the model file for emotion detection
!android/app/src/main/assets/face_landmarker.task
Comment on lines 41 to +43
Copy link

@coderabbitai coderabbitai bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Negation pattern is ineffective after ignoring parent directory.

Git ignores the entire android/ directory on line 41, so the negation on line 43 won't work—Git doesn't check children of already-ignored directories. To track a specific file inside an ignored directory, you must unignore the entire path hierarchy:

 # Ignore the entire Android directory
 android/
 # But keep the model file for emotion detection
-!android/app/src/main/assets/face_landmarker.task
+!android/app/
+!android/app/src/
+!android/app/src/main/
+!android/app/src/main/assets/
+!android/app/src/main/assets/face_landmarker.task

Alternatively, consider whether committing this binary asset to the repo is the right approach vs. downloading it during build or using Git LFS.

🤖 Prompt for AI Agents 
In @.gitignore around lines 41 - 43, The .gitignore currently ignores the entire
android/ directory so the negation for
!android/app/src/main/assets/face_landmarker.task is ineffective; update the
ignore rules to unignore the path hierarchy leading to that file (e.g., add
negations for android/app/, android/app/src/, android/app/src/main/,
android/app/src/main/assets/ before the specific file negation) or instead
remove the parent android/ ignore and/or use Git LFS or build-time download for
the binary asset if you don't want it committed.

android/app/src/main/java/com/expostarter/base/MainActivity.kt
android/app/src/main/java/com/expostarter/base/MainActivity.kt
.github/copilot-instructions.md
Comment on lines 44 to 46
Copy link

@coderabbitai coderabbitai bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Suspicious bare paths without ignore semantics.

Lines 44-46 list paths without a negation (!) or wildcard, yet they appear after an android/ ignore rule. If the intent was to ignore these specific files, they're already covered by android/. If the intent was to unignore them, they're missing the ! prefix. Additionally, line 44 and 45 are duplicates.

Please clarify the intent and remove or fix these entries.

🤖 Prompt for AI Agents 
In @.gitignore around lines 44 - 46, The .gitignore contains
redundant/suspicious entries: the duplicated
"android/app/src/main/java/com/expostarter/base/MainActivity.kt" and "
.github/copilot-instructions.md" after an existing "android/" rule; decide
whether you intended to ignore or unignore these files and fix accordingly: if
you meant to keep them ignored, remove the duplicate and the explicit android
path entries (they're already covered by "android/"); if you meant to unignore
them, prefix each path with "!" (e.g.,
"!android/app/src/main/java/com/expostarter/base/MainActivity.kt" and
"!.github/copilot-instructions.md") and remove the duplicate line; ensure no
duplicate lines remain.

rebuild.bat
public/database.sqlite
.idea/
Loading