Skip to content

Fix onLoadPlayerFile method #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ultrasquid9
Copy link
Contributor

The method should behave identically, it just has 8 less layers of nesting now


I agree to the Contributor License Agreement (CLA).

@bconlon1 bconlon1 self-requested a review June 20, 2025 00:56
@bconlon1 bconlon1 added the status/pending-review The issue references a pull request which is pending review. label Jun 20, 2025
@bconlon1 bconlon1 moved this from Back Log to Review Requested in The Aether Jun 20, 2025
Copy link
Contributor

@bconlon1 bconlon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from Review Requested to Review Approved in The Aether Jun 20, 2025
@bconlon1 bconlon1 merged commit b8ffe00 into The-Aether-Team:1.21.1-develop Jun 20, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in The Aether Jun 20, 2025
bconlon1 pushed a commit that referenced this pull request Jun 20, 2025
The method should behave identically, it just has 8 less layers of
nesting now

---

I agree to the Contributor License Agreement (CLA).

---------

Co-authored-by: Aether-Team-Bot <88561924+Aether-Team-Bot@users.noreply.github.com>
Co-authored-by: Aether-Team-Bot <machine@gildedgames.com>
(cherry picked from commit b8ffe00)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/pending-review The issue references a pull request which is pending review.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants