fix: better client login logs, fix dynamic pm detection

The-Best-Codes · Jan 6, 2025 · 67d5fef · 67d5fef
1 parent 3092671
commit 67d5fef
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "discraft",
-  "version": "1.6.2-beta.7",
+  "version": "1.6.2-beta.8",
   "description": "Ultimate Discord bot framework",
   "type": "module",
   "packageManager": "bun@1.1.42",

diff --git a/package/src/cli/init/detectPm.ts b/package/src/cli/init/detectPm.ts
@@ -1,13 +1,16 @@
 import { execSync } from "child_process";
 
+function getEnvVar(key: string): string | undefined {
+  // Create a completely isolated dynamic lookup.
+  // This is necessary to avoid static replacement of process.env.SOME_VARIABLE
+  if (Object.prototype.hasOwnProperty.call(process.env, key)) {
+    return process.env[key];
+  }
+  return undefined;
+}
+
 async function detectPackageManager(): Promise<string | undefined> {
-  // Access process.env dynamically to avoid static replacement during build
-  const userAgent = Object.prototype.hasOwnProperty.call(
-    process.env,
-    "npm_config_user_agent",
-  )
-    ? process.env.npm_config_user_agent
-    : undefined;
+  const userAgent = getEnvVar("npm_config_user_agent");
 
   if (userAgent) {
     if (userAgent.startsWith("bun")) {

diff --git a/templates/ts/index.ts b/templates/ts/index.ts
@@ -28,7 +28,9 @@ registerEvents(client)
       }
     });
     client.login(process.env.DISCORD_TOKEN).catch((err) => {
-      logger.error("Client login failed.");
+      logger.error(
+        "Client login failed, make sure your token is set correctly.",
+      );
       logger.verbose(err);
     });
   });