Merge pull request #6812 from eder-matheus/ppl_groups

ppl: support regex for pin groups
The-OpenROAD-Project · Mar 4, 2025 · a5258d6 · a5258d6
2 parents fb62c2c + e4be581
commit a5258d6
Show file tree

Hide file tree

Showing 9 changed files with 864 additions and 23 deletions.
diff --git a/src/ppl/src/IOPlacer.tcl b/src/ppl/src/IOPlacer.tcl
@@ -215,18 +215,7 @@ proc set_io_pin_constraint { args } {
       utl::error PPL 58 "The -pin_names argument is required when using -group flag."
     }
 
-    set pin_list {}
-    set final_group ""
-    foreach pin_name $group {
-      set db_bterm [$dbBlock findBTerm $pin_name]
-      if { $db_bterm != "NULL" } {
-        lappend pin_list $db_bterm
-        set final_group "$final_group $pin_name"
-      } else {
-        utl::warn PPL 47 "Group pin $pin_name not found in the design."
-      }
-    }
-
+    set pin_list [ppl::parse_pin_names "place_pins -group_pins" $group]
     if { [llength $pin_list] != 0 } {
       ppl::add_pin_group $pin_list [info exists flags(-order)]
       incr group_idx
@@ -636,16 +625,8 @@ proc place_pins { args } {
   if { [llength $pin_groups] != 0 } {
     set group_idx 0
     foreach group $pin_groups {
-      set pin_list {}
-      foreach pin_name $group {
-        set db_bterm [$dbBlock findBTerm $pin_name]
-        if { $db_bterm != "NULL" } {
-          lappend pin_list $db_bterm
-        } else {
-          utl::warn PPL 43 "Pin $pin_name not found in group $group_idx."
-        }
-      }
-      ppl::add_pin_group $pin_list 0
+      set pins [ppl::parse_pin_names "place_pins -group_pins" $group]
+      ppl::add_pin_group $pins 0
       incr group_idx
     }
   }

diff --git a/src/ppl/test/CMakeLists.txt b/src/ppl/test/CMakeLists.txt
@@ -62,6 +62,8 @@ or_integration_tests(
     group_pins8
     group_pins9
     group_pins10
+    group_pins11
+    group_pins12
     group_pins_error1
     group_pins_warn1
     invalid_layer