Make repeater hier #6629
Draft
Make repeater hier #6629
+457
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: andyfox-rushc <andy@rushc.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Do you expect this to have any impact on the non-hier flow? |
no. Please note I am seeing some failures in the regressions on the pull request (I don't see any locally here -- all the regressions pass on my version of ubuntu), so am digging ! Have marked the pull request as draft until I figure out why the regressions on other versions of ubuntu failing (am seeing some valgrind issues which I will dig into). |
Signed-off-by: andyfox-rushc <andy@rushc.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: andyfox-rushc <andy@rushc.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: andyfox-rushc <andy@rushc.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: andyfox-rushc <andy@rushc.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In timing driven placement the repairDesign part of the resizer is called which exercises the "makeRepeater" method. This pull request adds hierarchical support to the makeRepeater method. The key changes are: