Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odb/rcx: move parse.h/cpp odb->rcx #6785

Merged

Conversation

openroad-ci
Copy link
Collaborator

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

using odb::uint;
using utl::Logger;

class extProcess;
class Ath__parser;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: declaration uses identifier 'Ath__parser', which is a reserved identifier [bugprone-reserved-identifier]

Suggested change
class Ath__parser;
class Ath_parser;

src/rcx/include/rcx/extprocess.h:54:

-   void printConductor(FILE* fp, Ath__parser* parse);
-   bool readConductor(Ath__parser* parser);
-   bool setDoubleVal(Ath__parser* parser, const char* key, int n, double& val);
-   bool setIntVal(Ath__parser* parser, const char* key, int n, int& val);
+   void printConductor(FILE* fp, Ath_parser* parse);
+   bool readConductor(Ath_parser* parser);
+   bool setDoubleVal(Ath_parser* parser, const char* key, int n, double& val);
+   bool setIntVal(Ath_parser* parser, const char* key, int n, int& val);

src/rcx/include/rcx/extprocess.h:109:

-   bool readDielectric(Ath__parser* parser);
-   void printDielectric(FILE* fp, Ath__parser* parse);
+   bool readDielectric(Ath_parser* parser);
+   void printDielectric(FILE* fp, Ath_parser* parse);

src/rcx/include/rcx/extprocess.h:133:

-   bool setDoubleVal(Ath__parser* parser, const char* key, int n, double& val);
-   bool setIntVal(Ath__parser* parser, const char* key, int n, int& val);
+   bool setDoubleVal(Ath_parser* parser, const char* key, int n, double& val);
+   bool setIntVal(Ath_parser* parser, const char* key, int n, int& val);

src/rcx/include/rcx/extprocess.h:283:

-   int readWidthSpacing2D(Ath__parser* parser,
+   int readWidthSpacing2D(Ath_parser* parser,

src/rcx/include/rcx/extprocess.h:288:

-   Ath__array1D<double>* readDoubleArray(Ath__parser* parser,
+   Ath__array1D<double>* readDoubleArray(Ath_parser* parser,

src/rcx/include/rcx/extprocess.h:311:

-   int readVariation(Ath__parser* parser);
-   extVarTable* readVarTable(Ath__parser* parser,
+   int readVariation(Ath_parser* parser);
+   extVarTable* readVarTable(Ath_parser* parser,

src/rcx/include/rcx/extprocess.h:464:

-   void readDataRateTable(Ath__parser* parser, const char* keyword);
+   void readDataRateTable(Ath_parser* parser, const char* keyword);

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty merged commit cce2dbf into The-OpenROAD-Project:master Feb 27, 2025
9 of 11 checks passed
@maliberty maliberty deleted the mv-parse branch February 27, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants