rsz: Fix "buffer ball" issues #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Povišer <povik@cutebit.org>
When we break out of the repair loop we want to restore previous best result. Any changes done since we created the checkpoint has degraded timing. Signed-off-by: Martin Povišer <povik@cutebit.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Mar 3, 2025
|
If you make a |
|
OK, I've pushed test-rsz-fix-buffer-ball. Feel free to cancel the secure run if you don't think it's worth it. |
Signed-off-by: Martin Povišer <povik@cutebit.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Martin Povišer <povik@cutebit.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@maliberty CI green, we can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues with the resizer have conspired to create this "buffer ball" of split buffers connected back-to-back, see the commits. Cc @gudeh