Cts fix register top buffer position #6811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arthurjolo <arthurjolo@gmail.com>
Signed-off-by: arthurjolo <arthurjolo@gmail.com>
Signed-off-by: arthurjolo <arthurjolo@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
precisionmoon
approved these changes
Mar 5, 2025
|
@arthurjolo , please rebase flow test ibex_sky130hd after merging your branch with the master. |
Signed-off-by: arthurjolo <arthurjolo@gmail.com>
auto-merge was automatically disabled
March 5, 2025 16:53
Head branch was pushed to by a user without write access
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when CTS finds the position to place the top buffer for the register tree, that is the center of the register sink region, it considers the position of the buffer that was just created. Since the position of new instances is considered to be (0, 0) the sink region center is affected and the position of the root buffer is shifted to the bottom left.
This PR changes CTS to not consider the top buffer when finding its position avoiding this error.