DPO: support edge spacing #6813
Conversation
osamahammad21
commented
Mar 4, 2025
osamahammad21
commented
- Add Journal tracking for easier redo/undo operations.
- Move Grid class from dpl to dpo as an initial step to merge both modules.
- Fix wrong interpretation of row site count limit.
- Add support to LEF58_EDGESPACINGTABLE rule
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // GridY gridEndY(const Cell* cell) const; | ||
|
|
||
| int gridYToDbu(int y) const; | ||
| int gridXToDbu(int y) const; |
There was a problem hiding this comment.
warning: function 'dpo::Grid::gridXToDbu' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
int gridXToDbu(int y) const;
^Additional context
src/dpo/src/Grid.cxx:164: the definition seen here
int Grid::gridXToDbu(int x) const
^src/dpo/src/Grid.h:107: differing parameters are named here: ('y'), in definition: ('x')
int gridXToDbu(int y) const;
^| auto node = actions[i].getNode(); | ||
| updateBins(actions[i].getNode(), | ||
| actions[i].getOrigLeft() + 0.5 * node->getWidth(), | ||
| actions[i].getOrigBottom() + 0.5 * node->getHeight(), |
There was a problem hiding this comment.
warning: use range-based for loop instead [modernize-loop-convert]
| actions[i].getOrigBottom() + 0.5 * node->getHeight(), | |
| for (const auto & action : actions) { | |
| auto node = action.getNode(); | |
| updateBins(action.getNode(), | |
| action.getOrigLeft() + 0.5 * node->getWidth(), | |
| action.getOrigBottom() + 0.5 * node->getHeight(), |
| auto node = actions[i].getNode(); | ||
| updateBins(actions[i].getNode(), | ||
| actions[i].getNewLeft() + 0.5 * node->getWidth(), | ||
| actions[i].getNewBottom() + 0.5 * node->getHeight(), |
There was a problem hiding this comment.
warning: use range-based for loop instead [modernize-loop-convert]
| actions[i].getNewBottom() + 0.5 * node->getHeight(), | |
| for (const auto & action : actions) { | |
| auto node = action.getNode(); | |
| updateBins(action.getNode(), | |
| action.getNewLeft() + 0.5 * node->getWidth(), | |
| action.getNewBottom() + 0.5 * node->getHeight(), |
| orientPtr_->orientAdjust(nodes[i], newOri[i]); | ||
| } | ||
| for (int i = 0; i < changes.size(); i++) { | ||
| mgrPtr_->redo(changes[i], true); |
There was a problem hiding this comment.
warning: use range-based for loop instead [modernize-loop-convert]
| mgrPtr_->redo(changes[i], true); | |
| for (const auto & change : changes) { | |
| mgrPtr_->redo(change, true); |
| const std::vector<int>& newLeft, | ||
| const std::vector<int>& newBottom, | ||
| const std::vector<unsigned>& newOri) override; | ||
| double delta(const Journal& journal); |
There was a problem hiding this comment.
warning: 'delta' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
double delta(const Journal& journal);
^Additional context
src/dpo/src/detailed_objective.h:65: overridden virtual function is here
virtual double delta(const Journal& journal) = 0;
^| const std::vector<int>& newLeft, | ||
| const std::vector<int>& newBottom, | ||
| const std::vector<unsigned>& newOri) override; | ||
| double delta(const Journal& journal); |
There was a problem hiding this comment.
warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
| double delta(const Journal& journal); | |
| double delta(const Journal& journal) override; |
| orientPtr_->orientAdjust(nodes[i], newOri[i]); | ||
| } | ||
| for (int i = 0; i < changes.size(); i++) { | ||
| mgrPtr_->redo(changes[i], true); |
There was a problem hiding this comment.
warning: use range-based for loop instead [modernize-loop-convert]
| mgrPtr_->redo(changes[i], true); | |
| for (const auto & change : changes) { | |
| mgrPtr_->redo(change, true); |
| class Master | ||
| { | ||
| public: | ||
| Master() {} |
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
| Master() {} | |
| Master() = default; |
