Upf: fix set_isolation -update while using non-default values #6814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Yuki Imamura <lucasyuki@yahoo.com.br>
Signed-off-by: Lucas Yuki Imamura <lucasyuki@yahoo.com.br>
Signed-off-by: Lucas Yuki Imamura <lucasyuki@yahoo.com.br>
Signed-off-by: Lucas Yuki Imamura <lucasyuki@yahoo.com.br>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
updateargument from theset_isolationcommand.The
updateargument from theset_isolationcommand indicates that this command provides additional information for a previous command with the same strategy_name and domain_name.When using the
updateargument without providing values forisolation_senseorlocationOpenRoad was setting them to the default, ignoring previous values.Changes:
isolation_senseandlocationdefault values if it's not using theupdateargumentset_isolationdefault values added in the README