-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix all high slither errors #103
Conversation
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use
events-accessImpact: Low
Poolz-Helper/contracts/Fee/WhiteListHelper.sol Lines 23 to 26 in c46db8e
missing-zero-checkImpact: Low
Poolz-Helper/contracts/GovManager.sol Line 22 in c46db8e
pragmaImpact: Informational
low-level-callsImpact: Informational
Poolz-Helper/contracts/Fee/FeeBaseHelper.sol Lines 52 to 62 in c46db8e
naming-conventionImpact: Informational
Poolz-Helper/contracts/GovManager.sol Line 22 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDeal.sol Lines 5 to 10 in c46db8e
Poolz-Helper/contracts/token/ERC20Token.sol Lines 22 to 24 in c46db8e
Poolz-Helper/contracts/Array.sol Line 11 in c46db8e
Poolz-Helper/contracts/Array.sol Line 25 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 25 to 27 in c46db8e
Poolz-Helper/contracts/Array.sol Line 81 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 38 to 42 in c46db8e
Poolz-Helper/contracts/Array.sol Line 81 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 44 to 47 in c46db8e
Poolz-Helper/contracts/Array.sol Lines 25 to 37 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 29 to 32 in c46db8e
Poolz-Helper/contracts/Array.sol Lines 11 to 23 in c46db8e
Poolz-Helper/contracts/PozBenefit.sol Line 31 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 49 to 57 in c46db8e
Poolz-Helper/contracts/Array.sol Line 25 in c46db8e
Poolz-Helper/contracts/Array.sol Line 70 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 34 to 36 in c46db8e
Poolz-Helper/contracts/Array.sol Line 11 in c46db8e
Poolz-Helper/contracts/Array.sol Line 57 in c46db8e
Poolz-Helper/contracts/ETHHelper.sol Line 37 in c46db8e
Poolz-Helper/contracts/Array.sol Line 40 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 5 to 12 in c46db8e
Poolz-Helper/contracts/Array.sol Line 70 in c46db8e
Poolz-Helper/contracts/interfaces/ILockedDealV2.sol Lines 14 to 21 in c46db8e
unused-importImpact: Informational
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 99.06% 99.05% -0.01%
==========================================
Files 20 20
Lines 214 212 -2
Branches 48 48
==========================================
- Hits 212 210 -2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
This introduces breaking changes, as does the |
Quality Gate passedIssues Measures |
closes #102