Skip to content

made PayFee public#98

Merged
ashwinarora merged 16 commits intomasterfrom
fee-issue
Apr 19, 2024
Merged

made PayFee public#98
ashwinarora merged 16 commits intomasterfrom
fee-issue

Conversation

@ashwinarora
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.08%. Comparing base (304e86a) to head (e48697c).

❗ Current head e48697c differs from pull request most recent head 816a620. Consider uploading reports for the commit 816a620 to get more accurate results

Files Patch % Lines
contracts/mocks/WhiteListMock.sol 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #98      +/-   ##
===========================================
- Coverage   100.00%   99.08%   -0.92%     
===========================================
  Files           11       20       +9     
  Lines          144      219      +75     
  Branches        43       51       +8     
===========================================
+ Hits           144      217      +73     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Lomet Lomet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to make the class abstract and keep it internal?

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ashwinarora ashwinarora merged commit a36ba42 into master Apr 19, 2024
@ashwinarora ashwinarora deleted the fee-issue branch April 19, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants