Skip to content

Add extra line to DQ summary table for unknown appointment status #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2025

Conversation

francisbarton
Copy link
Collaborator

Closes issue #77

@francisbarton francisbarton self-assigned this Apr 1, 2025
Copy link
Member

@StatsRhian StatsRhian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff seems to be showing national data deleted?
deleted

Otherwise all good

@francisbarton
Copy link
Collaborator Author

francisbarton commented Apr 1, 2025

The new file is 667KB and the previous one was 671KB, so the -3KB thing is right, the 100% must just be because it's binary and github can't/doesn't actually work out how much of the file is changed.

That's really strange. The file is definitely there, with the correct data. I re-ran the export locally and the new .rda isn't showing as a new change in git, so should be the same as what's already pushed here.
I'm going to try another commit and see if it triggers anything!

@francisbarton francisbarton merged commit 83b592f into main Apr 2, 2025
1 check passed
@StatsRhian StatsRhian deleted the francisbarton/issue77 branch April 3, 2025 21:49
StatsRhian pushed a commit that referenced this pull request Apr 7, 2025
Add extra line to DQ summary table for unknown appointment status
StatsRhian pushed a commit that referenced this pull request Apr 11, 2025
Add extra line to DQ summary table for unknown appointment status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants