adds actions #8
Merged
adds actions #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjemmett
added
enhancement
- adds linting/format/type checking action - adds code coverage action
tomjemmett
force-pushed
the
add_actions
branch
from
292163f to
308b02a
Compare
arguments were being called at import time, not at run time. switches to calling the default value functions inside of the methods
tomjemmett
force-pushed
the
add_actions
branch
from
308b02a to
89eb6ac
Compare
yiwen-h
approved these changes
Sep 12, 2025
Member
yiwen-h
left a comment
yiwen-h
left a comment
There was a problem hiding this comment.
This PR does a few different things:
- Adds actions
- Makes it so that the default arguments are not evaluated at import
- Adds additional tests
Could we please also have a corresponding issue for the PR?
Have tested locally - all works as expected. Not evaluating the default arguments at import is useful for other repos e.g. nhp_products using this package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.