-
Notifications
You must be signed in to change notification settings - Fork 0
Changes to front end to replace mitigator with TPMA #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
matt-dray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think this covers all the user-facing instances, except for a couple: can you change 'mitigator' in inst/app/strategy_text/virtual_wards_activity_avoidance_heart_failure.md and virtual_wards_efficiencies_ari.md?
Also, I think we're going with 'mitigatable' rather than 'mitigable', based on Steven's email (1 Oct 2025) about terminology?
|
Or for these places could use 'Types of Activity'? |
|
In general, we should probably prefer 'TPMAs' or 'Types of Potentially-Mitigatable Activity' for consistency across products. But 'Types of activity' might work here to keep it short/without needing to use an initialism. |
matt-dray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've done find-in-files and rendered the app locally. I've pre-approved on the basis that one suggestion (a typo) is fixed.
There is a question about how best to introduce the use of TPMA to users; at the moment this is the only repo that has updated. At worst, we mention it in the model updates in project info (The-Strategy-Unit/nhp_project_information#292). Ideally, we update project info itself for this release (The-Strategy-Unit/nhp_project_information#280).
Co-authored-by: Matt Dray <18232097+matt-dray@users.noreply.github.com>
|
Cracking, pre-approved, so feel free to merge if nothing else to add. |


No description provided.