Skip to content

Conversation

@DCEW
Copy link
Contributor

@DCEW DCEW commented Oct 20, 2025

No description provided.

@DCEW DCEW self-assigned this Oct 20, 2025
@DCEW DCEW linked an issue Oct 20, 2025 that may be closed by this pull request
Copy link
Contributor

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this covers all the user-facing instances, except for a couple: can you change 'mitigator' in inst/app/strategy_text/virtual_wards_activity_avoidance_heart_failure.md and virtual_wards_efficiencies_ari.md?

Also, I think we're going with 'mitigatable' rather than 'mitigable', based on Steven's email (1 Oct 2025) about terminology?

@matt-dray
Copy link
Contributor

Just realised the full TPMA phrase is slightly too long for the width of the sidebar (even more so if 'mitigatable' rather than 'mitigable'), which also partially hides the expansion chevrons (<) for the sections below it.

@DCEW
Copy link
Contributor Author

DCEW commented Oct 21, 2025

Just realised the full TPMA phrase is slightly too long for the width of the sidebar (even more so if 'mitigatable' rather than 'mitigable'), which also partially hides the expansion chevrons (<) for the sections below it.

I did wonder if this would be an issue but can't run locally to check - will change to TPMA - I wonder if we need a static banner to spell out the whole TPMA on all pages, or is that overkill?

@DCEW
Copy link
Contributor Author

DCEW commented Oct 21, 2025

Or for these places could use 'Types of Activity'?

@matt-dray
Copy link
Contributor

In general, we should probably prefer 'TPMAs' or 'Types of Potentially-Mitigatable Activity' for consistency across products. But 'Types of activity' might work here to keep it short/without needing to use an initialism.

@DCEW DCEW requested a review from matt-dray October 22, 2025 08:08
Copy link
Contributor

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've done find-in-files and rendered the app locally. I've pre-approved on the basis that one suggestion (a typo) is fixed.

There is a question about how best to introduce the use of TPMA to users; at the moment this is the only repo that has updated. At worst, we mention it in the model updates in project info (The-Strategy-Unit/nhp_project_information#292). Ideally, we update project info itself for this release (The-Strategy-Unit/nhp_project_information#280).

Co-authored-by: Matt Dray <18232097+matt-dray@users.noreply.github.com>
@matt-dray
Copy link
Contributor

Cracking, pre-approved, so feel free to merge if nothing else to add.

@DCEW DCEW merged commit 3646345 into main Oct 24, 2025
3 checks passed
@DCEW DCEW deleted the mitigator_to_tpma branch October 24, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the term 'mitigator' in the user interface

3 participants