Skip to content

Conversation

@matt-dray
Copy link
Contributor

@matt-dray matt-dray commented Nov 21, 2025

Close #33.

  • Added golem-config.yml, functions to read and wrangle, and extract axes labels for trend plots.
  • Standardised variable and argument labelling and ordering.
  • Removed some outdated code.
  • Replaced azkit::get_container() with a local get_container() function in R/fct_azure.R and deployed it (see content or standalone links).

Example of dynamic axes with one TPMA:

And having changed to another TPMA:

@matt-dray matt-dray added this to the v0.2.0 milestone Nov 21, 2025
@matt-dray matt-dray self-assigned this Nov 21, 2025
@matt-dray matt-dray requested a review from DCEW as a code owner November 21, 2025 14:34
@matt-dray matt-dray added enhancement New feature or request priority: must MoSCoW priority labels Nov 21, 2025
@DCEW
Copy link

DCEW commented Nov 24, 2025

I'm having a click through, but for me its only populating the trend plot - none of the others not the tables, have I not updated a relevant access requirement or something? (but dynamic y-axes appear to be working - still need to fix the overlapping FYs but think that's in another issue)

@matt-dray
Copy link
Contributor Author

Hello, I've now removed azkit::get_container() and replaced it with a local get_container() function in R/fct_azure.R, which means it is now deployed.

You'll see that all the tables/charts get populated as expected. I couldn't recreate the issue you had locally, but I will send .Renviron contents to you separately in case you're missing anything that may have caused a problem.

@matt-dray
Copy link
Contributor Author

And you're right: not yet concentrating on chart themes and design, but that's covered in #30.

Copy link

@DCEW DCEW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, yes, looks ok deployed, thanks.

@matt-dray matt-dray merged commit 83151d0 into main Nov 26, 2025
2 checks passed
@matt-dray matt-dray deleted the 33-config branch November 26, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: must MoSCoW priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate config for plots, etc

3 participants