Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup UI tests for lints #31

Closed
BD103 opened this issue Sep 3, 2024 · 1 comment · Fixed by #125 or #128
Closed

Setup UI tests for lints #31

BD103 opened this issue Sep 3, 2024 · 1 comment · Fixed by #125 or #128
Labels
A-CI Related to CI and GitHub Actions A-Linter Related to the linter and custom lints C-Testing A change to the tests
Milestone
`bevy_lint` 0.1.0

Comments

@BD103
Copy link
Member

BD103 commented Sep 3, 2024

UI tests ensure that errors and warnings are correctly raised for given code cases. This can verify that lints fire when they're supposed to, and don't in all other occasions. I think ui_test would be great for this, since this is what the main bevy repo uses.
@BD103 BD103 added A-CI Related to CI and GitHub Actions A-Linter Related to the linter and custom lints C-Testing A change to the tests labels Sep 3, 2024
@TheBevyFlock TheBevyFlock deleted a comment Sep 3, 2024
@janhohenheim

This comment was marked as resolved.

Sign in to view
@BD103 BD103 mentioned this issue Sep 3, 2024
Closed
@BD103 BD103 added this to the `bevy_lint` 0.1.0 milestone Sep 28, 2024
This was referenced Oct 4, 2024
Merged
Merged
@BD103 BD103 linked a pull request Oct 10, 2024 that will close this issue
Add UI tests for existing lints #128
Merged
BD103 added a commit that referenced this issue Oct 13, 2024
@BD103
Add UI tests for existing lints (#128)
603a7c6 
Part of #31.

This is a continuation of #125 that actually adds UI tests for all of
the current lints. It was split off to make #125 easier to review.

To test this, run:

```bash
cargo test -p bevy_lint --test ui
```

To bless changes, run:

```bash
cargo test -p bevy_lint --test ui -- --bless
```

There are a few additional options available if you replace `--bless`
with `--help`, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Related to CI and GitHub Actions A-Linter Related to the linter and custom lints C-Testing A change to the tests
Projects
None yet
Milestone
`bevy_lint` 0.1.0
2 participants
@janhohenheim @BD103