-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI tests for existing lints #128
Conversation
You'll probably notice the large file count when reviewing this PR. This is due to a multitude of reasons:
If you ever have trouble understanding a test, it's usually my fault and not yours. Please let me know if that's the case! You can also consult |
With that all out of the way, I've finished writing tests for all of our lints! This is ready for review, once #125 is merged. :) |
#125 is merged, so this is ready for review now! |
ad94cda
to
4086aa3
Compare
4086aa3
to
9954aba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to have tests for these.
Left some minor comments, but feel free to merge once you think it's ready.
Part of #31.
This is a continuation of #125 that actually adds UI tests for all of the current lints. It was split off to make #125 easier to review.
To test this, run:
cargo test -p bevy_lint --test ui
To bless changes, run:
cargo test -p bevy_lint --test ui -- --bless
There are a few additional options available if you replace
--bless
with--help
, too.