Bevy build #102
Merged
Bevy build #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
added
A-CI
TimJentzsch
added
A-CLI
BD103
reviewed
Sep 27, 2024
|
In general, this change looks good! I love how easy I have a few comments and there are some merge conflicts, but then it's good to go! |
TimJentzsch
commented
Sep 28, 2024
| @@ -1,3 +1,4 @@ | |||
| #![expect(dead_code, reason = "Will be used for bevy bump and perhaps bevy run")] | |||
There was a problem hiding this comment.
Not sure why this lint wasn't emitted before...
BD103
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the remaining pieces needed for the
bevy buildcommand.The command is a wrapper around
cargo build, but with an additionalwebsub command which makes it a lot easier to build an app for the browser.I also plan to add additional features in the feature, like #68.
The PR contains the following changes:
cargo installwrapper to install a program if it's missing (prompting the user).Cargo.toml. There are likely better ways to do this (perhaps viacargo metadata), but I already had this implemented and we can improve it in a follow-up if needed.If you'd prefer smaller PRs let me know and I will split this up further.