Skip to content

Replace lower_ty() with typeck_results.node_type() #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BD103 merged 1 commit into from
Oct 7, 2024
Merged

Replace lower_ty() with typeck_results.node_type() #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bevy_lint/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
extern crate rustc_driver;
extern crate rustc_errors;
extern crate rustc_hir;
extern crate rustc_hir_analysis;
extern crate rustc_interface;
extern crate rustc_lint;
extern crate rustc_middle;
Expand Down
5 changes: 1 addition & 4 deletions bevy_lint/src/lints/insert_event_resource.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ use clippy_utils::{
};
use rustc_errors::Applicability;
use rustc_hir::{Expr, ExprKind, GenericArg, GenericArgs, Path, PathSegment, QPath};
use rustc_hir_analysis::lower_ty;
use rustc_lint::{LateContext, LateLintPass};
use rustc_middle::ty::{Ty, TyKind};
use rustc_session::declare_lint_pass;
Expand Down Expand Up @@ -153,9 +152,7 @@ fn check_init_resource<'tcx>(cx: &LateContext<'tcx>, path: &PathSegment<'tcx>, m
{
// Lower `rustc_hir::Ty` to `ty::Ty`, so we can inspect type information. For more
// information, see <https://rustc-dev-guide.rust-lang.org/ty.html#rustc_hirty-vs-tyty>.
// Note that `lower_ty()` is quasi-deprecated, and should be removed if a adequate
// replacement is found.
let resource_ty = lower_ty(cx.tcx, resource_hir_ty);
let resource_ty = cx.typeck_results().node_type(resource_hir_ty.hir_id);

// If the resource type is `Events<T>`, emit the lint.
if match_type(cx, resource_ty, &crate::paths::EVENTS) {
Expand Down