Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup to nightly-2024-10-03 #153

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Rustup to nightly-2024-10-03 #153

merged 1 commit into from
Oct 17, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Oct 17, 2024

With the release of Rust 1.82, it's time to update our pinned nightly Rust and clippy_utils version.

Why update now?

A stable version of Rust releases every 6 weeks. Each release takes 12 weeks (3-4 months) to depart from nightly, enter beta, then become stable. If bevy_lint's pinned nightly version is older than 12 weeks, it will start failing to compile stable Rust code! We can't have that!

As such, the pinned version needs to be updated periodically to stay ahead of stable Rust.

How often should we update?

I propose every 6 weeks, alongside each new stable Rust version. It will keep us 2 releases ahead of stable while still giving us plenty of time to fix bugs and release.

How should this affect version numbers?

Bumping the Rust version (dubbed "Rustup") should be considered a patch change, and as such will increment bevy_lint's version number by 0.0.1. (At a minimum, features and breaking changes may make the version increase by more, based on SemVer.)

How did you update?

I updated clippy_utils to the latest commit and version, and I copied their rust-toolchain.toml version for that same commit.

I then ran checks and tests, as well as browsed the commits to clippy_utils to make sure nothing we use changed.

@BD103 BD103 added A-Linter Related to the linter and custom lints C-Dependencies A change related to dependencies labels Oct 17, 2024
Copy link
Collaborator

@bas-ie bas-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump it!

@BD103 BD103 merged commit 1cb8e3a into main Oct 17, 2024
8 checks passed
@BD103 BD103 deleted the rustup branch October 17, 2024 23:27
@BD103 BD103 changed the title Rustup to nightly-2024-08-21 Rustup to nightly-2024-10-03 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Related to the linter and custom lints C-Dependencies A change related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants