Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Rust 1.82, it's time to update our pinned nightly Rust and
clippy_utils
version.Why update now?
A stable version of Rust releases every 6 weeks. Each release takes 12 weeks (3-4 months) to depart from nightly, enter beta, then become stable. If
bevy_lint
's pinned nightly version is older than 12 weeks, it will start failing to compile stable Rust code! We can't have that!As such, the pinned version needs to be updated periodically to stay ahead of stable Rust.
How often should we update?
I propose every 6 weeks, alongside each new stable Rust version. It will keep us 2 releases ahead of stable while still giving us plenty of time to fix bugs and release.
How should this affect version numbers?
Bumping the Rust version (dubbed "Rustup") should be considered a patch change, and as such will increment
bevy_lint
's version number by0.0.1
. (At a minimum, features and breaking changes may make the version increase by more, based on SemVer.)How did you update?
I updated
clippy_utils
to the latest commit and version, and I copied theirrust-toolchain.toml
version for that same commit.I then ran checks and tests, as well as browsed the commits to
clippy_utils
to make sure nothing we use changed.