-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release bevy_lint
v0.1.0
#172
Conversation
The following I'll add to the description of the Github release:
|
I couldn't find a list of the current lints and lint categories when exploring the docs, including information about which lints are on by default. This is a critical piece of information, and should be created / made very prominent before the initial release of bevy_lint. |
This is to make it clear that the `docs` folder is not a user's guide, but the contributor's guide.
Good call! I made a few changes that should make this clearer, though most further improvements would require larger changes that I'd rather push back until a later release. Take a look at my most recent 4 commits on this PR, and tell me if it's enough! |
One of our dependencies was yanked, this avoids a warning when running the install command with --locked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the clarity here now :D
This fixes some errors that were temporarily enabled, then later disabled upstream.
I've bumped the Rust toolchain version, as the old pinned nightly still had the |
I missed these two changes in #172, I was too excited to press the merge button!
As per the release checklist, this PR kicks off the release for
bevy_lint
v0.1.0. Now is the time to assess its current features, review any outstanding changes or bugs, and run tests on real-world projects.Once this pull request is approved by at least one core Bevy maintainer, I will merge it and create the Github release, then open a post-release PR setting up for v0.2.0-dev. Between the time this is merged and the post-release PR is merged there will be a feature freeze, preventing all other PRs related to
bevy_lint
from being merged. While I would appreciate freezingbevy_cli
PRs as well for aesthetic reasons, it's not a requirement. :)