Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate backend and CLI #25

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Separate backend and CLI #25

merged 3 commits into from
Sep 2, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Sep 1, 2024

Closes #21.

This PR implements the advise given by @sixfold-origami on Discord. It makes bevy_cli is proper library, moving all clap logic to main.rs. It also moves main.rs and lint_driver.rs to the src/bin folder, so they are distinct from library modules.

I also added a few comments to Cargo.toml in 7d22ab7 in a drive-by pass.

@BD103 BD103 added C-Code-Quality An improvement of readability or quality A-Cross-Cutting Affects multiple areas of the repository labels Sep 1, 2024
sixfold-origami
sixfold-origami approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@sixfold-origami sixfold-origami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes and they look good! We might want to move the bin files to their own crate eventually, but I reckon this is fine for now.

@sixfold-origami sixfold-origami enabled auto-merge (squash) September 2, 2024 01:08
@sixfold-origami sixfold-origami merged commit 8b718fa into main Sep 2, 2024
6 checks passed
@sixfold-origami sixfold-origami deleted the cli-backend branch September 2, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixfold-origami sixfold-origami sixfold-origami approved these changes

Assignees
No one assigned
Labels
A-Cross-Cutting Affects multiple areas of the repository C-Code-Quality An improvement of readability or quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate into backend and CLI
2 participants
@BD103 @sixfold-origami