Remove direct dependency on bevy_lint from bevy_cli#30
Merged
Conversation
janhohenheim
reviewed
Sep 3, 2024
janhohenheim
reviewed
Sep 3, 2024
janhohenheim
reviewed
Sep 3, 2024
janhohenheim
approved these changes
Sep 3, 2024
Member
janhohenheim
left a comment
There was a problem hiding this comment.
Looks good, just some minor suggestions :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
bevy_lintoptional when installingbevy_cli. This solves a number of issue:bevy_lintcrate, you used to have to runcargo build -p bevy_cli --bin bevy_lint_driverfor them to be applied.In order to do this, I:
bevy linta facade command that passes all arguments to abevy_lintbinary, if it can be found.bevy_lintbinary to thebevy_lintcrate, and movedbevy_lint_drivertobevy_lint.Now, nothing lint-related will be installed if
bevy_lintisn't except for the facade command.