Add comms to config page and small code refactor #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zainrax
reviewed
Sep 24, 2024
html/config.html
Outdated
| </tr> | ||
|
|
||
| <tr> | ||
| <td>Bluetooth Enablued</td> |
There was a problem hiding this comment.
*Bluetooth Enabled
though kind of funny to leave as EnaBLUEd
There was a problem hiding this comment.
Haha, should probably fix it..
Zainrax
approved these changes
Sep 24, 2024
html/config.html
Outdated
| <td><input type="text" id="input-comms-protect-species"></td> | ||
| </tr> | ||
| <tr> | ||
| <td>Protect Species</td> |
static/js/config.js
Outdated
| "bluetooth": document.querySelector("#input-comms-bluetooth").checked, | ||
| "power-output": document.querySelector("#input-comms-power-output").value || undefined, | ||
| "power-up-duration": document.querySelector("#input-comms-power-up-duration").value || undefined, | ||
| "trap-species": JSON.parse(document.querySelector("#input-comms-trap-species").value) || undefined, |
There was a problem hiding this comment.
Should be fine, but careful of parsing JSON as it will throw instead of defaulting to undefined if it's invalid
try {
protectSpecies = JSON.parse(document.querySelector("#input-comms-protect-species").value);
} catch (e) {
console.error("Invalid JSON for Protect Species:", e);
protectSpecies = undefined;
alert("Please enter valid JSON for Protect Species.");
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.